Re: [PATCH] Fix ICE with -Wodr (PR middle-end/61913)

2014-07-28 Thread Richard Biener
On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek pola...@redhat.com wrote: Wodr in common.opt was missing a Var, which means: 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c; 2) -Wno-odr wouldn't work. Thus fixed. I'd think this doesn't need a testcase... Bootstrapped/regtested on

Re: [PATCH] Fix ICE with -Wodr (PR middle-end/61913)

2014-07-28 Thread Jan Hubicka
On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek pola...@redhat.com wrote: Wodr in common.opt was missing a Var, which means: 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c; 2) -Wno-odr wouldn't work. Thus fixed. I'd think this doesn't need a testcase...

Re: [PATCH] Fix ICE with -Wodr (PR middle-end/61913)

2014-07-28 Thread Marek Polacek
On Mon, Jul 28, 2014 at 10:23:36AM +0200, Jan Hubicka wrote: On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek pola...@redhat.com wrote: Wodr in common.opt was missing a Var, which means: 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c; 2) -Wno-odr wouldn't work. Thus fixed.

Re: [PATCH] Fix ICE with -Wodr (PR middle-end/61913)

2014-07-28 Thread Jan Hubicka
On Mon, Jul 28, 2014 at 10:23:36AM +0200, Jan Hubicka wrote: On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek pola...@redhat.com wrote: Wodr in common.opt was missing a Var, which means: 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c; 2) -Wno-odr wouldn't work. Thus

[PATCH] Fix ICE with -Wodr (PR middle-end/61913)

2014-07-27 Thread Marek Polacek
Wodr in common.opt was missing a Var, which means: 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c; 2) -Wno-odr wouldn't work. Thus fixed. I'd think this doesn't need a testcase... Bootstrapped/regtested on x86_64-linux, ok for trunk? 2014-07-27 Marek Polacek pola...@redhat.com