Re: [PATCH] Fix NetBSD bootstrap

2016-11-19 Thread Krister Walfridsson
On Thu, 17 Nov 2016, Joseph Myers wrote: I'll presume you know best about the choices of stdint.h types. You may wish to consider what the correct value of use_gcc_stdint is - the default "none" (rely on the system's header), or "wrap" (use GCC's header in freestanding mode) or "provide"

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Joseph Myers
I'll presume you know best about the choices of stdint.h types. You may wish to consider what the correct value of use_gcc_stdint is - the default "none" (rely on the system's header), or "wrap" (use GCC's header in freestanding mode) or "provide" (always use GCC's header). Note that GCC's

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Mike Stump
> On Nov 16, 2016, at 11:23 AM, Krister Walfridsson > wrote: > > On Wed, 16 Nov 2016, Mike Stump wrote: > >> Looks reasonable. The biggest issue would be if any of those values changed >> through time, and the current version works for older netbsd releases,

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Krister Walfridsson
On Wed, 16 Nov 2016, Mike Stump wrote: Looks reasonable. The biggest issue would be if any of those values changed through time, and the current version works for older netbsd releases, the patch could break them. Of course, I don't have any visibility into how any of those values might

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Mike Stump
> On Nov 16, 2016, at 9:12 AM, Krister Walfridsson > wrote: > > NetBSD fails bootstrap with > stdatomic.h:55:17: error: unknown type name '__INT_LEAST8_TYPE__' > This is fixed by the following patch (only i386 and x86_64 for now. I'll > do the other ports after

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Bernd Schmidt
On 11/16/2016 06:12 PM, Krister Walfridsson wrote: I'm the NetBSD maintainer, so I belive I don't need approval to commit this. But I have been absent for a long time, so it makes sense for someone to review at least this first patch. Bootstrapped and tested on i386-unknown-netbsdelf6.1 and

[PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Krister Walfridsson
NetBSD fails bootstrap with stdatomic.h:55:17: error: unknown type name '__INT_LEAST8_TYPE__' This is fixed by the following patch (only i386 and x86_64 for now. I'll do the other ports after fixing some more issues -- the NetBSD support is rather broken at the moment...) I'm the NetBSD