Re: [PATCH] Fix PR68707

2016-01-11 Thread Christophe Lyon
On 10 January 2016 at 13:15, Thomas Schwinge wrote: > Hi! > > On Fri, 8 Jan 2016 11:30:16 +, Alan Lawrence > wrote: >> Here's an alternative patch, [...] > >> +/* { dg-final { scan-tree-dump "note: Built SLP cancelled: can use >>

Re: [PATCH] Fix PR68707

2016-01-10 Thread Thomas Schwinge
Hi! On Fri, 8 Jan 2016 11:30:16 +, Alan Lawrence wrote: > Here's an alternative patch, [...] > +/* { dg-final { scan-tree-dump "note: Built SLP cancelled: can use > load/store-lanes" { target { vect_perm && vect_load_lanes } } } } */ For all these, you're missing

[PATCH] Fix PR68707

2016-01-08 Thread Alan Lawrence
Here's an alternative patch, using the hunk from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68707#c16, which 'improves' (heh, we think) on the previous by allowing SLP to proceed where the loads are strided, for example, slp-perm-11.c. Also I fix the testsuite failures (looking for SLP where

Re: [PATCH] Fix PR68707

2016-01-08 Thread Richard Biener
On Fri, 8 Jan 2016, Alan Lawrence wrote: > Here's an alternative patch, using the hunk from > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68707#c16, which 'improves' (heh, > we think) on the previous by allowing SLP to proceed where the loads are > strided, for example, slp-perm-11.c. Also I fix

Re: [PATCH] Fix PR68707

2016-01-08 Thread Richard Earnshaw (lists)
On 08/01/16 11:45, Richard Biener wrote: > On Fri, 8 Jan 2016, Alan Lawrence wrote: > >> Here's an alternative patch, using the hunk from >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68707#c16, which 'improves' >> (heh, >> we think) on the previous by allowing SLP to proceed where the loads

Re: [PATCH] Fix PR68707, 67323

2015-12-17 Thread Alan Lawrence
On 16/12/15 15:01, Richard Biener wrote: The following patch adds a heuristic to prefer store/load-lanes over SLP when vectorizing. Compared to the variant attached to the PR I made the STMT_VINFO_STRIDED_P behavior explicit (matching what you've tested). Not sure I follow this. Compared to

Re: [PATCH] Fix PR68707, 67323

2015-12-17 Thread Alan Lawrence
On 17/12/15 10:46, Richard Biener wrote: On Thu, 17 Dec 2015, Alan Lawrence wrote: On 16/12/15 15:01, Richard Biener wrote: The following patch adds a heuristic to prefer store/load-lanes over SLP when vectorizing. Compared to the variant attached to the PR I made the STMT_VINFO_STRIDED_P

Re: [PATCH] Fix PR68707, 67323

2015-12-17 Thread Richard Biener
On Thu, 17 Dec 2015, Alan Lawrence wrote: > On 16/12/15 15:01, Richard Biener wrote: > > > > The following patch adds a heuristic to prefer store/load-lanes > > over SLP when vectorizing. Compared to the variant attached to > > the PR I made the STMT_VINFO_STRIDED_P behavior explicit (matching

[PATCH] Fix PR68707, 67323

2015-12-16 Thread Richard Biener
The following patch adds a heuristic to prefer store/load-lanes over SLP when vectorizing. Compared to the variant attached to the PR I made the STMT_VINFO_STRIDED_P behavior explicit (matching what you've tested). It's a heuristic that may end up vectorizing less loops or loops in a less