Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-07 Thread Richard Biener
On Fri, 3 Feb 2017, Iain Sandoe wrote: > > > On 2 Feb 2017, at 08:08, Richard Biener wrote: > > > > On Wed, 1 Feb 2017, Segher Boessenkool wrote: > > > >> On Wed, Feb 01, 2017 at 03:53:09PM -0600, Segher Boessenkool wrote: > >>> On Wed, Feb 01, 2017 at 11:59:10AM +0100,

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-03 Thread Iain Sandoe
> On 2 Feb 2017, at 08:08, Richard Biener wrote: > > On Wed, 1 Feb 2017, Segher Boessenkool wrote: > >> On Wed, Feb 01, 2017 at 03:53:09PM -0600, Segher Boessenkool wrote: >>> On Wed, Feb 01, 2017 at 11:59:10AM +0100, Richard Biener wrote: Wasn't successful in making a

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-02 Thread Richard Biener
On Wed, 1 Feb 2017, Segher Boessenkool wrote: > On Wed, Feb 01, 2017 at 03:53:09PM -0600, Segher Boessenkool wrote: > > On Wed, Feb 01, 2017 at 11:59:10AM +0100, Richard Biener wrote: > > > Wasn't successful in making a cross to ppc64-linux build its libobjc. > > > > I'll do a native build.

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Segher Boessenkool
On Wed, Feb 01, 2017 at 03:53:09PM -0600, Segher Boessenkool wrote: > On Wed, Feb 01, 2017 at 11:59:10AM +0100, Richard Biener wrote: > > Wasn't successful in making a cross to ppc64-linux build its libobjc. > > I'll do a native build. Just the patch in the first message in this > thread? And

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Segher Boessenkool
On Tue, Jan 31, 2017 at 10:01:46AM +0100, Richard Biener wrote: > * doc/tm.texi.in (ADJUST_FIELD_ALIGN): Adjust to take additional > type parameter. > * doc/tm.texi: Regenerate. You didn't include tm.texi.in in the patch, only tm.texi . Segher

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Segher Boessenkool
On Wed, Feb 01, 2017 at 11:59:10AM +0100, Richard Biener wrote: > Wasn't successful in making a cross to ppc64-linux build its libobjc. I'll do a native build. Just the patch in the first message in this thread? And just running the testsuite is enough, or is there something specific you want

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Jakub Jelinek
On Wed, Feb 01, 2017 at 10:27:27AM -0500, Trevor Saunders wrote: > Yeah, different targets deal with this mess in different ways, looks > like frv uses a different macro and ppc redefines macros as needed > rs6000_special_adjust_field_align_p is also defined in ppc headers. > > > > > /* @@@ A

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Trevor Saunders
On Wed, Feb 01, 2017 at 09:42:08AM +0100, Richard Biener wrote: > On Tue, 31 Jan 2017, Jeff Law wrote: > > > On 01/31/2017 02:01 AM, Richard Biener wrote: > > > > > > This amends ADJUST_FIELD_ALIGN to always get the type of the field > > > as argument but make the field itself optional. All

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Richard Biener
On Wed, 1 Feb 2017, Iain Sandoe wrote: > > > On 1 Feb 2017, at 08:42, Richard Biener wrote: > > > > On Tue, 31 Jan 2017, Jeff Law wrote: > > > >> On 01/31/2017 02:01 AM, Richard Biener wrote: > >>> > >>> This amends ADJUST_FIELD_ALIGN to always get the type of the field >

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Iain Sandoe
> On 1 Feb 2017, at 08:42, Richard Biener wrote: > > On Tue, 31 Jan 2017, Jeff Law wrote: > >> On 01/31/2017 02:01 AM, Richard Biener wrote: >>> >>> This amends ADJUST_FIELD_ALIGN to always get the type of the field >>> as argument but make the field itself optional. All

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Richard Biener
On Tue, 31 Jan 2017, Jeff Law wrote: > On 01/31/2017 02:01 AM, Richard Biener wrote: > > > > This amends ADJUST_FIELD_ALIGN to always get the type of the field > > as argument but make the field itself optional. All actual target > > macro implementations only look at the type of the field but

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-01-31 Thread Jeff Law
On 01/31/2017 02:01 AM, Richard Biener wrote: This amends ADJUST_FIELD_ALIGN to always get the type of the field as argument but make the field itself optional. All actual target macro implementations only look at the type of the field but FRV (which seems to misuse ADJUST_FIELD_ALIGN to do

[PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-01-31 Thread Richard Biener
This amends ADJUST_FIELD_ALIGN to always get the type of the field as argument but make the field itself optional. All actual target macro implementations only look at the type of the field but FRV (which seems to misuse ADJUST_FIELD_ALIGN to do bitfield layout rather than using one of the three