Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

[Mike Stump]

On Jan 27, 2012, at 11:47 AM, Andreas Schwab wrote:
 Ok, the option is only recognized when it is mentioned in the specs, and
 neither darwin nor aix configurations have %{G*} in their CC1_SPEC, same
 for osf or vms on alpha.  Checked in the following as obvious.

Thanks.

Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

[Andreas Schwab]

Ok, the option is only recognized when it is mentioned in the specs, and
neither darwin nor aix configurations have %{G*} in their CC1_SPEC, same
for osf or vms on alpha.  Checked in the following as obvious.

Andreas.

2012-01-27  Andreas Schwab  sch...@linux-m68k.org

* g++.dg/cpp0x/constexpr-rom.C: Don't add -G0 on *-*-darwin*
*-*-aix* alpha*-*-osf* alpha*-*-*vms*.

diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C 
b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
index 636f0e7..5213d59 100644
--- a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
+++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
@@ -1,6 +1,6 @@
 // PR c++/49673: check that test_data goes into .rodata
 // { dg-options -std=c++0x }
-// { dg-additional-options -G0 { target alpha*-*-* frv*-*-* ia64-*-* lm32*-*-* 
m32r*-*-* microblaze*-*-* mips*-*-* powerpc*-*-* rs6000*-*-* score*-*-* } }
+// { dg-additional-options -G0 { target { { alpha*-*-* frv*-*-* ia64-*-* 
lm32*-*-* m32r*-*-* microblaze*-*-* mips*-*-* powerpc*-*-* rs6000*-*-* 
score*-*-* }  { ! { *-*-darwin* *-*-aix* alpha*-*-osf* alpha*-*-*vms* } } } } 
}
 // { dg-final { scan-assembler \\.rdata { target mips*-*-* } } }
 // { dg-final { scan-assembler rodata { target { { *-*-linux-gnu || *-*-elf 
}  { ! mips*-*-* } } } } }
 

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.

Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

[Dominique Dhumieres]

 * g++.dg/cpp0x/constexpr-rom.C: Add -G0 where applicable.

It fails on powerpc-apple-darwin9 with

FAIL: g++.dg/cpp0x/constexpr-rom.C (test for excess errors)
Excess errors:
g++: error: unrecognized option '-G'

TIA

Dominique

Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

[Andreas Schwab]

domi...@lps.ens.fr (Dominique Dhumieres) writes:

 * g++.dg/cpp0x/constexpr-rom.C: Add -G0 where applicable.

 It fails on powerpc-apple-darwin9 with

 FAIL: g++.dg/cpp0x/constexpr-rom.C (test for excess errors)
 Excess errors:
 g++: error: unrecognized option '-G'

That is strange, g.opt is added to extra_options for all powerpc*-*-* in
config.gcc.  The only target that removes something from extra_options
is xstormy16-*-elf.

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.

[PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

[Andreas Schwab]

Fix spurious failure by disabling use of sdata.  Tested on
powerpc-linux.

Andreas.

2012-01-14  Andreas Schwab sch...@linux-m68k.org

* g++.dg/cpp0x/constexpr-rom.C: Add -G0 where applicable.

diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C 
b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
index aa9ff5d..5853ea1 100644
--- a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
+++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
@@ -1,5 +1,6 @@
 // PR c++/49673: check that test_data goes into .rodata
 // { dg-options -std=c++0x }
+// { dg-options -std=c++0x -G0 { target alpha*-*-* frv*-*-* ia64-*-* 
lm32*-*-* m32r*-*-* microblaze*-*-* mips*-*-* powerpc*-*-* rs6000*-*-* 
score*-*-* } }
 // { dg-final { scan-assembler \\.rdata { target mips*-*-* } } }
 // { dg-final { scan-assembler rodata { target { { *-*-linux-gnu || *-*-elf 
}  { ! mips*-*-* } } } } }
 
-- 
1.7.8.3

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.

Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

[Jakub Jelinek]

On Sat, Jan 14, 2012 at 08:57:00PM +0100, Andreas Schwab wrote:
 Fix spurious failure by disabling use of sdata.  Tested on
 powerpc-linux.

Please use dg-additional-options instead.

 2012-01-14  Andreas Schwab sch...@linux-m68k.org
 
   * g++.dg/cpp0x/constexpr-rom.C: Add -G0 where applicable.
 
 diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C 
 b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
 index aa9ff5d..5853ea1 100644
 --- a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
 +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
 @@ -1,5 +1,6 @@
  // PR c++/49673: check that test_data goes into .rodata
  // { dg-options -std=c++0x }
 +// { dg-options -std=c++0x -G0 { target alpha*-*-* frv*-*-* ia64-*-* 
 lm32*-*-* m32r*-*-* microblaze*-*-* mips*-*-* powerpc*-*-* rs6000*-*-* 
 score*-*-* } }
  // { dg-final { scan-assembler \\.rdata { target mips*-*-* } } }
  // { dg-final { scan-assembler rodata { target { { *-*-linux-gnu || 
 *-*-elf }  { ! mips*-*-* } } } } }

Jakub

Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

[Andreas Schwab]

Thanks, I hadn't discovered this yet.

Andreas.

2012-01-14  Andreas Schwab sch...@linux-m68k.org

* g++.dg/cpp0x/constexpr-rom.C: Add -G0 where applicable.

diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C 
b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
index aa9ff5d..636f0e7 100644
--- a/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
+++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-rom.C
@@ -1,5 +1,6 @@
 // PR c++/49673: check that test_data goes into .rodata
 // { dg-options -std=c++0x }
+// { dg-additional-options -G0 { target alpha*-*-* frv*-*-* ia64-*-* lm32*-*-* 
m32r*-*-* microblaze*-*-* mips*-*-* powerpc*-*-* rs6000*-*-* score*-*-* } }
 // { dg-final { scan-assembler \\.rdata { target mips*-*-* } } }
 // { dg-final { scan-assembler rodata { target { { *-*-linux-gnu || *-*-elf 
}  { ! mips*-*-* } } } } }
 
-- 
1.7.8.3


-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.