Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-17 Thread John David Anglin
On 2016-01-11, at 10:56 AM, John David Anglin wrote: > On 2016-01-11 8:24 AM, Jakub Jelinek wrote: >> On Mon, Jan 11, 2016 at 02:16:31PM +0100, Christophe Lyon wrote: > In any case, we have no_c99_libc_has_function on hpux and everything on > linux. So, I > don't think testing with

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-14 Thread Szabolcs Nagy
On 14/01/16 15:02, Andre Vieira (lists) wrote: Unfortunately c99_functions is a very wide net. For instance, newlib supports the ceill, but doesn't support wscanf_s nor any bounds checking function I think. wscanf_s is not c99 (it is in the optional annex k of c11, which is likely to be

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-14 Thread Andre Vieira (lists)
On 11/01/16 16:39, Jakub Jelinek wrote: On Mon, Jan 11, 2016 at 05:11:21PM +0100, Christophe Lyon wrote: I tested a similar version on my side. It just makes the test become UNSUPPORTED for arm/aarch64 + newlib. They used to pass, though. Is anything bad on that? The test tests functions

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-11 Thread Christophe Lyon
On 9 January 2016 at 17:48, Jakub Jelinek wrote: > On Thu, Dec 31, 2015 at 12:52:21PM -0500, John David Anglin wrote: >> On 2015-12-30, at 6:46 PM, Joseph Myers wrote: >> >> > On Mon, 28 Dec 2015, John David Anglin wrote: >> > >> >> The attach change fixes PR middle-end/68743 on

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-11 Thread Jakub Jelinek
On Mon, Jan 11, 2016 at 02:16:31PM +0100, Christophe Lyon wrote: > >> In any case, we have no_c99_libc_has_function on hpux and everything on > >> linux. So, I > >> don't think testing with function_c99_misc on hppa will show any > >> difference. > >> > >> Okay with function_c99_misc? > > > >

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-11 Thread Jakub Jelinek
On Mon, Jan 11, 2016 at 05:11:21PM +0100, Christophe Lyon wrote: > I tested a similar version on my side. It just makes the test become > UNSUPPORTED for arm/aarch64 + newlib. They used to pass, though. Is anything bad on that? The test tests functions that newlib does not implement, so it is

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-11 Thread Christophe Lyon
On 11 January 2016 at 16:56, John David Anglin wrote: > On 2016-01-11 8:24 AM, Jakub Jelinek wrote: >> >> On Mon, Jan 11, 2016 at 02:16:31PM +0100, Christophe Lyon wrote: > > In any case, we have no_c99_libc_has_function on hpux and everything on > linux. So, I

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-11 Thread Szabolcs Nagy
On 11/01/16 16:39, Jakub Jelinek wrote: On Mon, Jan 11, 2016 at 05:11:21PM +0100, Christophe Lyon wrote: I tested a similar version on my side. It just makes the test become UNSUPPORTED for arm/aarch64 + newlib. They used to pass, though. Is anything bad on that? The test tests functions

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-11 Thread John David Anglin
On 2016-01-11 8:24 AM, Jakub Jelinek wrote: On Mon, Jan 11, 2016 at 02:16:31PM +0100, Christophe Lyon wrote: In any case, we have no_c99_libc_has_function on hpux and everything on linux. So, I don't think testing with function_c99_misc on hppa will show any difference. Okay with

Re: [PATCH] Fix math transformation on targets without c99 math functions

2016-01-09 Thread Jakub Jelinek
On Thu, Dec 31, 2015 at 12:52:21PM -0500, John David Anglin wrote: > On 2015-12-30, at 6:46 PM, Joseph Myers wrote: > > > On Mon, 28 Dec 2015, John David Anglin wrote: > > > >> The attach change fixes PR middle-end/68743 on hppa*-*-hpux*. In > >> compiling > >> c99_functions.c in libgfortran,

Re: [PATCH] Fix math transformation on targets without c99 math functions

2015-12-31 Thread John David Anglin
On 2015-12-30, at 6:46 PM, Joseph Myers wrote: > On Mon, 28 Dec 2015, John David Anglin wrote: > >> The attach change fixes PR middle-end/68743 on hppa*-*-hpux*. In compiling >> c99_functions.c in libgfortran, floor ((double)x) was transformed to >> floorf(x) but >> floorf is not available on

Re: [PATCH] Fix math transformation on targets without c99 math functions

2015-12-30 Thread Joseph Myers
On Mon, 28 Dec 2015, John David Anglin wrote: > The attach change fixes PR middle-end/68743 on hppa*-*-hpux*. In compiling > c99_functions.c in libgfortran, floor ((double)x) was transformed to > floorf(x) but > floorf is not available on hppa*-*-hpux*. The change simply adds a >

[PATCH] Fix math transformation on targets without c99 math functions

2015-12-28 Thread John David Anglin
The attach change fixes PR middle-end/68743 on hppa*-*-hpux*. In compiling c99_functions.c in libgfortran, floor ((double)x) was transformed to floorf(x) but floorf is not available on hppa*-*-hpux*. The change simply adds a libc_has_function check to prevent the transformation. Tested on