Re: [PATCH] Fix various issues in vect_analyze_data_refs (PR middle-end/59150)

2014-02-08 Thread Jakub Jelinek
On Thu, Feb 06, 2014 at 10:04:00AM +0100, Richard Biener wrote: PS, just looking at the patch now again, in the light of PR59594 the reordering of datarefs before goto again looks also wrong, we IMHO have to perform a vector ordered remove in that case, ok to handle it as a follow-up?

Re: [PATCH] Fix various issues in vect_analyze_data_refs (PR middle-end/59150)

2014-02-08 Thread Richard Biener
On Sat, Feb 8, 2014 at 10:25 AM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Feb 06, 2014 at 10:04:00AM +0100, Richard Biener wrote: PS, just looking at the patch now again, in the light of PR59594 the reordering of datarefs before goto again looks also wrong, we IMHO have to perform a

Re: [PATCH] Fix various issues in vect_analyze_data_refs (PR middle-end/59150)

2014-02-06 Thread Richard Biener
On Thu, 6 Feb 2014, Jakub Jelinek wrote: Hi! This patch fixes a double free on simd-lane access if get_vectype_for_scalar_type fails (the new dr is already in datarefs[i] and if we free_data_ref it, it will be free_data_ref'ed again at the end of the failed vectorization), fixes handling

[PATCH] Fix various issues in vect_analyze_data_refs (PR middle-end/59150)

2014-02-05 Thread Jakub Jelinek
Hi! This patch fixes a double free on simd-lane access if get_vectype_for_scalar_type fails (the new dr is already in datarefs[i] and if we free_data_ref it, it will be free_data_ref'ed again at the end of the failed vectorization), fixes handling of clobbers (plugs a memory leak due to missed