Re: [PATCH] Introduce instance discriminators

2018-08-06 Thread Alexandre Oliva
On Jul 30, 2018, Alexandre Oliva wrote: >> for gcc/ada >> * trans.c: Include debug.h. >> (file_map): New static variable. >> (gigi): Set it. Create decl_to_instance_map when needed. >> (Subprogram_Body_to_gnu): Pass gnu_subprog_decl to... >> (Sloc_to_locus): ... this. Add decl parm, map it

Re: [PATCH] Introduce instance discriminators

2018-07-31 Thread Arnaud Charlet
>>> Ok to install the first two patches? (the third is just for reference) >> >> Ping? >> >> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01419.html > > OK for the middle-end parts, the Ada parts need separate approval > (maybe CC a maintainer). Ok for the Ada part. Arno

Re: [PATCH] Introduce instance discriminators

2018-07-31 Thread Richard Biener
On Tue, Jul 31, 2018 at 12:35 AM Alexandre Oliva wrote: > > On Jul 24, 2018, Alexandre Oliva wrote: > > > Ok to install the first two patches? (the third is just for reference) > > Ping? > > https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01419.html OK for the middle-end parts, the Ada parts

Re: [PATCH] Introduce instance discriminators

2018-07-30 Thread Alexandre Oliva
On Jul 24, 2018, Alexandre Oliva wrote: > Ok to install the first two patches? (the third is just for reference) Ping? https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01419.html > Introduce instance discriminators > From: Alexandre Oliva > With -gnateS, the Ada compiler sets itself up to

Re: [PATCH] Introduce instance discriminators

2018-07-24 Thread Alexandre Oliva
On Jul 19, 2018, Richard Biener wrote: > Oh, that probably wasn't omitted on purpose. Cary said it was used > for profiling but I can't see any such use. > Is the instance discriminator stuff also used for profiling? Not that I know, but... I probably wouldn't know yet ;-) Anyway, it was

Re: [PATCH] Introduce instance discriminators

2018-07-19 Thread Richard Biener
On Thu, Jul 19, 2018 at 9:21 AM Alexandre Oliva wrote: > > On Jul 18, 2018, Richard Biener wrote: > > > On Wed, Jul 18, 2018 at 8:53 AM Alexandre Oliva wrote: > >> Instance discriminators are not compatible with LTO, in that the > >> instance mapping is not preserved in LTO dumps. There are no

Re: [PATCH] Introduce instance discriminators

2018-07-19 Thread Alexandre Oliva
On Jul 18, 2018, Richard Biener wrote: > On Wed, Jul 18, 2018 at 8:53 AM Alexandre Oliva wrote: >> Instance discriminators are not compatible with LTO, in that the >> instance mapping is not preserved in LTO dumps. There are no plans to >> preserve discriminators in them. > Because... ... it

Re: [PATCH] Introduce instance discriminators

2018-07-18 Thread Richard Biener
On Wed, Jul 18, 2018 at 8:53 AM Alexandre Oliva wrote: > > This patch is a rewrite of an earlier patch submitted at > https://gcc.gnu.org/ml/gcc-patches/2012-11/msg02340.html > > With -gnateS, the Ada compiler sets itself up to output discriminators > for different instantiations of generics, but

[PATCH] Introduce instance discriminators

2018-07-18 Thread Alexandre Oliva
This patch is a rewrite of an earlier patch submitted at https://gcc.gnu.org/ml/gcc-patches/2012-11/msg02340.html With -gnateS, the Ada compiler sets itself up to output discriminators for different instantiations of generics, but the middle and back ends have lacked support for that. This patch