RE: [PATCH] MIPS: Prevent buffer overrun in uninitialised variable fix

2017-04-20 Thread Matthew Fortune
Jakub Jelinek writes: > On Thu, Apr 20, 2017 at 12:49:49PM +, Matthew Fortune wrote: > > Hi Jeff, > > > > I missed a load of test failures while on vacation and just noticed > > that the fix you did for a potentially uninitialized variable warning > > is overwriting the stack and breaking MSA

Re: [PATCH] MIPS: Prevent buffer overrun in uninitialised variable fix

2017-04-20 Thread Jakub Jelinek
On Thu, Apr 20, 2017 at 12:49:49PM +, Matthew Fortune wrote: > Hi Jeff, > > I missed a load of test failures while on vacation and just noticed > that the fix you did for a potentially uninitialized variable warning > is overwriting the stack and breaking MSA in MIPS. > > I guess you may have

[PATCH] MIPS: Prevent buffer overrun in uninitialised variable fix

2017-04-20 Thread Matthew Fortune
Hi Jeff, I missed a load of test failures while on vacation and just noticed that the fix you did for a potentially uninitialized variable warning is overwriting the stack and breaking MSA in MIPS. I guess you may have intended to set the length appropriately and only zero the elements that would