Re: [PATCH] PR c/69993: improvements to wording of -Wmisleading-indentation

2016-03-22 Thread David Malcolm
On Tue, 2016-03-01 at 20:18 +0100, Richard Biener wrote: > On March 1, 2016 7:51:01 PM GMT+01:00, David Malcolm < > dmalc...@redhat.com> wrote: > > The wording of our output from -Wmisleading-indentation is rather > > confusing, as noted by Reddit user "sysop073" here: > >

Re: [PATCH] PR c/69993: improvements to wording of -Wmisleading-indentation

2016-03-02 Thread Manuel López-Ibáñez
On 02/03/16 04:20, Patrick Palka wrote: Using this wording order makes it seem that the problem is with the if statement, because we emit a warning about it and then emit "only" a note for the misleadingly-indented goto statement. ... on second thought, I may be overthinking the semantic

Re: [PATCH] PR c/69993: improvements to wording of -Wmisleading-indentation

2016-03-01 Thread Patrick Palka
On Tue, Mar 1, 2016 at 3:29 PM, Patrick Palka wrote: > On Tue, Mar 1, 2016 at 1:51 PM, David Malcolm wrote: >> The wording of our output from -Wmisleading-indentation is rather >> confusing, as noted by Reddit user "sysop073" here: >> >>

Re: [PATCH] PR c/69993: improvements to wording of -Wmisleading-indentation

2016-03-01 Thread Patrick Palka
On Tue, Mar 1, 2016 at 1:51 PM, David Malcolm wrote: > The wording of our output from -Wmisleading-indentation is rather > confusing, as noted by Reddit user "sysop073" here: > >

Re: [PATCH] PR c/69993: improvements to wording of -Wmisleading-indentation

2016-03-01 Thread Richard Biener
On March 1, 2016 7:51:01 PM GMT+01:00, David Malcolm wrote: >The wording of our output from -Wmisleading-indentation is rather >confusing, as noted by Reddit user "sysop073" here:

[PATCH] PR c/69993: improvements to wording of -Wmisleading-indentation

2016-03-01 Thread David Malcolm
The wording of our output from -Wmisleading-indentation is rather confusing, as noted by Reddit user "sysop073" here: https://www.reddit.com/r/programming/comments/47pejg/gcc_6_wmisleadingindentation_vs_goto_fail/d0eonwd > The way they split up the warning looks designed to trick you. >