Re: [PATCH] PR fortran/89943 -- Duplicate BIND(c) allowed (?)

2019-10-14 Thread Paul Richard Thomas
Steve, Brilliant! Yes, it's good to commit. Thanks Paul On Mon, 14 Oct 2019 at 21:06, Steve Kargl wrote: > > See attached patch. It includes my previous patch and > patch to check for C1550. OK to commit? > > 2019-10-14 Steven G. Kargl > > PR fortran/89943 > decl.c

Re: [PATCH] PR fortran/89943 -- Duplicate BIND(c) allowed (?)

2019-10-14 Thread Steve Kargl
See attached patch. It includes my previous patch and patch to check for C1550. OK to commit? 2019-10-14 Steven G. Kargl PR fortran/89943 decl.c (gfc_match_function_decl): Ignore duplicate BIND(C) for function declaration in submodule. Implement at check for F2018

Re: [PATCH] PR fortran/89943 -- Duplicate BIND(c) allowed (?)

2019-10-12 Thread Paul Richard Thomas
Hi Steve, In the F2018 standard: C1550 (R1526) If MODULE appears in the prefix of a module subprogram and a binding label is specified, it shall be the same as the binding label specified in the corresponding module procedure interface body. While it does not say explicitly that a repeat binding

Re: [PATCH] PR fortran/89943 -- Duplicate BIND(c) allowed (?)

2019-10-11 Thread Steve Kargl
PING. On Fri, Oct 04, 2019 at 03:26:53PM -0700, Steve Kargl wrote: > The attached patch allows the declaration of a BIND(C) > module function or module subroutine to appear in a > submodule (see testcases). Regression test was clean. > OK to commit? > > Before a rubber stamped 'OK'. I do NOT

[PATCH] PR fortran/89943 -- Duplicate BIND(c) allowed (?)

2019-10-04 Thread Steve Kargl
The attached patch allows the declaration of a BIND(C) module function or module subroutine to appear in a submodule (see testcases). Regression test was clean. OK to commit? Before a rubber stamped 'OK'. I do NOT use submodules. A submodule user needs to pipe up on the validity of the patch.