Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-12 Thread Jonathan Wakely
On 11/01/17 13:25 +, Jonathan Wakely wrote: On 11/01/17 08:04 -0500, Tim Song wrote: On Wed, Jan 11, 2017 at 7:21 AM, Jonathan Wakely wrote: This patch uses the _Enable_default_constructor mixin to properly delete the default constructors. It's a bit cumbersome,

Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-11 Thread Tim Song
On Wed, Jan 11, 2017 at 8:30 AM, Jonathan Wakely wrote: >>> Re the new DMI, my brain compiler says that _Sequence c = _Sequence(); >>> breaks anything with an explicit copy/move constructor pre-C++17, but >>> I also don't think we care about those, right? >> >> >> I dislike

Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-11 Thread Jonathan Wakely
On 11/01/17 13:25 +, Jonathan Wakely wrote: On 11/01/17 08:04 -0500, Tim Song wrote: On Wed, Jan 11, 2017 at 7:21 AM, Jonathan Wakely wrote: This patch uses the _Enable_default_constructor mixin to properly delete the default constructors. It's a bit cumbersome,

Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-11 Thread Jonathan Wakely
On 11/01/17 08:04 -0500, Tim Song wrote: On Wed, Jan 11, 2017 at 7:21 AM, Jonathan Wakely wrote: This patch uses the _Enable_default_constructor mixin to properly delete the default constructors. It's a bit cumbersome, because we have to add an initializer for the base

Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-11 Thread Tim Song
On Wed, Jan 11, 2017 at 7:21 AM, Jonathan Wakely wrote: > This patch uses the _Enable_default_constructor mixin to properly > delete the default constructors. It's a bit cumbersome, because we > have to add an initializer for the base class to every > ctor-initializer-list,

Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-11 Thread Jonathan Wakely
On 10/01/17 13:15 -0500, Tim Song wrote: On Tue, Jan 10, 2017 at 12:33 PM, Jonathan Wakely wrote: The standard says that the container adaptors have a constructor with a default argument, which serves as a default constructor. That involves default-constructing the

Re: [PATCH] PR77528 add default constructors for container adaptors

2017-01-10 Thread Tim Song
On Tue, Jan 10, 2017 at 12:33 PM, Jonathan Wakely wrote: > The standard says that the container adaptors have a constructor with > a default argument, which serves as a default constructor. That > involves default-constructing the underlying sequence as the default > argument

[PATCH] PR77528 add default constructors for container adaptors

2017-01-10 Thread Jonathan Wakely
The standard says that the container adaptors have a constructor with a default argument, which serves as a default constructor. That involves default-constructing the underlying sequence as the default argument and then move-constructing the member variable from that argument. Because std::deque