Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

Hi Jakub: Got it, thanks, however I don't have commit right yet, can you commit it? On Tue, Jan 17, 2017 at 6:13 PM, Jakub Jelinek wrote: > On Tue, Jan 17, 2017 at 06:09:29PM +0800, Kito Cheng wrote: >> Hi Jakub: >> >> Thanks for your review, attachment is v2 patch, it's also

Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

On Tue, Jan 17, 2017 at 06:09:29PM +0800, Kito Cheng wrote: > Hi Jakub: > > Thanks for your review, attachment is v2 patch, it's also run > regression with x86-64, mips64, riscv64 and riscv32. > and additional, I've run gcc 6 branch with this patch, fix mips64 and > riscv64 and no > introduce new

Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

Hi Jakub: Thanks for your review, attachment is v2 patch, it's also run regression with x86-64, mips64, riscv64 and riscv32. and additional, I've run gcc 6 branch with this patch, fix mips64 and riscv64 and no introduce new regression on x86-64 and riscv32 on 6/trunk, it's ok for trunk and

RE: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

Kito Cheng writes: > On Mon, Jan 16, 2017 at 02:42:08PM +0800, Kito Cheng wrote: > > 2017-01-16 Kito Cheng > > Kuan-Lin Chen > > > > PR target/PR79079 > > * gcc/internal-fn.c (expand_mul_overflow):

Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

On Mon, Jan 16, 2017 at 02:42:08PM +0800, Kito Cheng wrote: > 2017-01-16 Kito Cheng > Kuan-Lin Chen > > PR target/PR79079 > * gcc/internal-fn.c (expand_mul_overflow): Use convert_modes instead > of >

[PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target

expand function on __builtin_mul_overflow is missing gen a truncdisi2 after muldi3 since it's just call gen_lowpart and it's not consider TRULY_NOOP_TRUNCATION == false, This patch has been run gcc testsuite for mips64, x86-64 and riscv64/riscv32, fix mips64 and riscv64 for