Re: [PATCH] RFA (gimplify.h) Fix incorrect cp/ use of get_formal_tmp_var.

2019-10-15 Thread Richard Biener
On Mon, Oct 14, 2019 at 10:25 PM Jason Merrill wrote: > > The comment for get_formal_tmp_var says that it shouldn't be used for > expressions whose value might change between initialization and use, and in > this case we're creating a temporary precisely because the value might > change, so we

Re: [PATCH] RFA (gimplify.h) Fix incorrect cp/ use of get_formal_tmp_var.

2019-10-15 Thread Aldy Hernandez
On 10/14/19 4:25 PM, Jason Merrill wrote: The comment for get_formal_tmp_var says that it shouldn't be used for expressions whose value might change between initialization and use, and in this case we're creating a temporary precisely because the value might change, so we should use

[PATCH] RFA (gimplify.h) Fix incorrect cp/ use of get_formal_tmp_var.

2019-10-14 Thread Jason Merrill
The comment for get_formal_tmp_var says that it shouldn't be used for expressions whose value might change between initialization and use, and in this case we're creating a temporary precisely because the value might change, so we should use get_initialized_tmp_var instead. I also noticed that