Re: [PATCH] Retry to emit global variables in HSA (PR hsa/70234)

2016-03-21 Thread Martin Liška
On 03/17/2016 07:21 PM, Martin Jambor wrote: > Hopefully the linear search in m_global_symbols never becomes > prohibitively expensive. But it is only necessary when > is_in_global_vars is true, so at least we could do something like: > > if (is_in_global_vars && !sym->m_emitted_to_brig) >

Re: [PATCH] Retry to emit global variables in HSA (PR hsa/70234)

2016-03-19 Thread Martin Jambor
Hi, On Tue, Mar 15, 2016 at 12:59:03PM +0100, Martin Liska wrote: > Hi. > > As emission of a HSAIL function can fail for various reason (-Whsa), > we must guarantee that a global variable is declared and at maximum once. > > Following patch does that, patch can survive make check-target-libgomp

[PATCH] Retry to emit global variables in HSA (PR hsa/70234)

2016-03-15 Thread Martin Liška
Hi. As emission of a HSAIL function can fail for various reason (-Whsa), we must guarantee that a global variable is declared and at maximum once. Following patch does that, patch can survive make check-target-libgomp and HSAILAsm is happy with BRIG output of declare_target-5.c source file.