It might be better to separate the data structure name change
(niter_desc to loop_desc) into a different patch. Other than that, the
patch looks good to me (for google branches only) Unroller really needs
more heuristics like this instead of just looking at size.
David
Fixed the stylist suggestions. Other responses below.
On Tue, Apr 24, 2012 at 10:22 PM, davi...@google.com wrote:
http://codereview.appspot.com/6099055/diff/1/loop-unroll.c
File loop-unroll.c (right):
http://codereview.appspot.com/6099055/diff/1/loop-unroll.c#newcode156
loop-unroll.c:156:
http://codereview.appspot.com/6099055/diff/1/loop-unroll.c
File loop-unroll.c (right):
http://codereview.appspot.com/6099055/diff/1/loop-unroll.c#newcode156
loop-unroll.c:156: static bool
An empty line here.
http://codereview.appspot.com/6099055/diff/1/loop-unroll.c#newcode182