Re: [PATCH] c++/modules: fix virtual destructors [PR103499]

2023-11-09 Thread Nathan Sidwell
On 11/9/23 18:29, Nathaniel Shead wrote: On Thu, Nov 09, 2023 at 05:57:39PM -0500, Nathan Sidwell wrote: On 11/9/23 04:55, Nathaniel Shead wrote: I'm not sure if this is just papering over a general issue of clones not being exported/imported, or if this is just an exception to the general

Re: [PATCH] c++/modules: fix virtual destructors [PR103499]

2023-11-09 Thread Nathaniel Shead
On Thu, Nov 09, 2023 at 05:57:39PM -0500, Nathan Sidwell wrote: > On 11/9/23 04:55, Nathaniel Shead wrote: > > I'm not sure if this is just papering over a general issue of clones not > > being > > exported/imported, or if this is just an exception to the general case of > > clones being able to

Re: [PATCH] c++/modules: fix virtual destructors [PR103499]

2023-11-09 Thread Nathan Sidwell
On 11/9/23 04:55, Nathaniel Shead wrote: I'm not sure if this is just papering over a general issue of clones not being exported/imported, or if this is just an exception to the general case of clones being able to be freely regenerated with no other issues. Alternatively, would it be better to

[PATCH] c++/modules: fix virtual destructors [PR103499]

2023-11-09 Thread Nathaniel Shead
I'm not sure if this is just papering over a general issue of clones not being exported/imported, or if this is just an exception to the general case of clones being able to be freely regenerated with no other issues. Alternatively, would it be better to override the DECL_VINDEX of the original