Re: [PATCH] c++: Fix ICE with ill-formed array list-initialization [PR93712]

2020-02-19 Thread Jason Merrill
On 2/19/20 7:30 PM, Marek Polacek wrote: On Fri, Feb 14, 2020 at 09:12:58AM +0100, Jason Merrill wrote: On 2/13/20 8:56 PM, Marek Polacek wrote: My P0388R4 patch changed build_array_conv to create an identity conversion at the start of the conversion chain. Hmm, an identity conversion of {}

Re: [PATCH] c++: Fix ICE with ill-formed array list-initialization [PR93712]

2020-02-19 Thread Marek Polacek
On Fri, Feb 14, 2020 at 09:12:58AM +0100, Jason Merrill wrote: > On 2/13/20 8:56 PM, Marek Polacek wrote: > > My P0388R4 patch changed build_array_conv to create an identity > > conversion at the start of the conversion chain. > > Hmm, an identity conversion of {} suggests that it has a type,

Re: [PATCH] c++: Fix ICE with ill-formed array list-initialization [PR93712]

2020-02-14 Thread Jason Merrill
On 2/13/20 8:56 PM, Marek Polacek wrote: My P0388R4 patch changed build_array_conv to create an identity conversion at the start of the conversion chain. Hmm, an identity conversion of {} suggests that it has a type, which it doesn't in the language. I'm not strongly against it, but what was

[PATCH] c++: Fix ICE with ill-formed array list-initialization [PR93712]

2020-02-13 Thread Marek Polacek
My P0388R4 patch changed build_array_conv to create an identity conversion at the start of the conversion chain. That was a sound change but now we crash in convert_like_real 7457 case ck_identity: 7458 if (BRACE_ENCLOSED_INITIALIZER_P (expr)) 7459 { 7460 int