Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-25 Thread Patrick Palka via Gcc-patches
On Mon, 24 Oct 2022, Nathan Sidwell wrote: > On 10/21/22 09:11, Patrick Palka wrote: > > On Fri, 21 Oct 2022, Nathan Sidwell wrote: > > > > > > > Thanks for the explanation, it's a situation I didn;t anticipate and your > > > fix > > > is good. Could you add a comment about why you need to

Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-24 Thread Nathan Sidwell via Gcc-patches
On 10/21/22 09:11, Patrick Palka wrote: On Fri, 21 Oct 2022, Nathan Sidwell wrote: Thanks for the explanation, it's a situation I didn;t anticipate and your fix is good. Could you add a comment about why you need to propagate the values though? Thanks a lot, will do. Just to make sure

Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-21 Thread Patrick Palka via Gcc-patches
On Fri, 21 Oct 2022, Nathan Sidwell wrote: > On 10/19/22 09:55, Patrick Palka wrote: > > On Wed, 19 Oct 2022, Richard Biener wrote: > > > > > On Tue, Oct 18, 2022 at 8:26 PM Patrick Palka wrote: > > > > > > > > On Fri, 14 Oct 2022, Richard Biener wrote: > > > > > > > > > On Thu, Oct 13, 2022

Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-21 Thread Nathan Sidwell via Gcc-patches
On 10/19/22 09:55, Patrick Palka wrote: On Wed, 19 Oct 2022, Richard Biener wrote: On Tue, Oct 18, 2022 at 8:26 PM Patrick Palka wrote: On Fri, 14 Oct 2022, Richard Biener wrote: On Thu, Oct 13, 2022 at 5:40 PM Patrick Palka via Gcc-patches wrote: Here during stream in we end up having

Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-19 Thread Patrick Palka via Gcc-patches
On Wed, 19 Oct 2022, Richard Biener wrote: > On Tue, Oct 18, 2022 at 8:26 PM Patrick Palka wrote: > > > > On Fri, 14 Oct 2022, Richard Biener wrote: > > > > > On Thu, Oct 13, 2022 at 5:40 PM Patrick Palka via Gcc-patches > > > wrote: > > > > > > > > Here during stream in we end up having

Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-19 Thread Richard Biener via Gcc-patches
On Tue, Oct 18, 2022 at 8:26 PM Patrick Palka wrote: > > On Fri, 14 Oct 2022, Richard Biener wrote: > > > On Thu, Oct 13, 2022 at 5:40 PM Patrick Palka via Gcc-patches > > wrote: > > > > > > Here during stream in we end up having created a type variant for the enum > > > before we read the

Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-18 Thread Patrick Palka via Gcc-patches
On Fri, 14 Oct 2022, Richard Biener wrote: > On Thu, Oct 13, 2022 at 5:40 PM Patrick Palka via Gcc-patches > wrote: > > > > Here during stream in we end up having created a type variant for the enum > > before we read the enum's definition, and thus the variant inherited stale > > TYPE_VALUES

Re: [PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-14 Thread Richard Biener via Gcc-patches
On Thu, Oct 13, 2022 at 5:40 PM Patrick Palka via Gcc-patches wrote: > > Here during stream in we end up having created a type variant for the enum > before we read the enum's definition, and thus the variant inherited stale > TYPE_VALUES and TYPE_MIN/MAX_VALUES, which leads to an ICE (with -g).

[PATCH] c++ modules: verify_type failure with typedef enum [PR106848]

2022-10-13 Thread Patrick Palka via Gcc-patches
Here during stream in we end up having created a type variant for the enum before we read the enum's definition, and thus the variant inherited stale TYPE_VALUES and TYPE_MIN/MAX_VALUES, which leads to an ICE (with -g). The stale variant got created from set_underlying_type during earlier stream