Re: [PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-07-27 Thread Eric Botcazou
> What I was trying to highlight is that rolling my own solution like > this makes missing regressions more likely than having a shared > solution would. But 'make mail-report.log' is precisely the shared solution, no need to reinvent the wheel here. -- Eric Botcazou

Re: [PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-07-27 Thread Martin Sebor
On 07/27/2018 10:17 AM, Eric Botcazou wrote: FWIW, there are 128 failures in the GCC test suite on x86_64. Many of these have been there for weeks (e.g., the lto failures due to PR86004), even years (guality). My script to compare the results against a baseline uses the following regular

Re: [PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-07-27 Thread Eric Botcazou
> FWIW, there are 128 failures in the GCC test suite on x86_64. > Many of these have been there for weeks (e.g., the lto failures > due to PR86004), even years (guality). My script to compare > the results against a baseline uses the following regular > expression to extract the names of failing

Re: [PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-07-27 Thread Martin Sebor
On 07/27/2018 03:05 AM, Eric Botcazou wrote: I missed your approval and didn't get to committing the patch until today. While retesting it on top of fresh trunk I noticed a few test failures due to other recent strlen changes. I made adjustments to the patch to avoid most of them and opened

Re: [PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-07-27 Thread Eric Botcazou
> I missed your approval and didn't get to committing the patch > until today. While retesting it on top of fresh trunk I noticed > a few test failures due to other recent strlen changes. I made > adjustments to the patch to avoid most of them and opened bug > 86688 for one that I think needs a

Re: [PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-07-26 Thread Martin Sebor
On 06/29/2018 11:05 AM, Jeff Law wrote: On 06/07/2018 09:57 AM, Martin Sebor wrote: The attached patch enhances the strlen pass to more consistently deal with MEM_REF assignments (PR 86042) and to track string lengths across calls to memcpy that overwrite parts of a string with sequences of

Re: [PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-06-29 Thread Jeff Law
On 06/07/2018 09:57 AM, Martin Sebor wrote: > The attached patch enhances the strlen pass to more consistently > deal with MEM_REF assignments (PR 86042) and to track string > lengths across calls to memcpy that overwrite parts of a string > with sequences of non-nul characters (PR 86043). > >

[PATCH] enhance strlen to understand MEM_REF and partial overlaps (PR 86042, 86043)

2018-06-07 Thread Martin Sebor
The attached patch enhances the strlen pass to more consistently deal with MEM_REF assignments (PR 86042) and to track string lengths across calls to memcpy that overwrite parts of a string with sequences of non-nul characters (PR 86043). Fixes for both bugs rely on changes to the same code so I