Re: [PATCH] sel-sched: run cleanup_cfg just before loop_optimizer_init (PR 84659)

2018-04-12 Thread Andrey Belevantsev
On 12.04.2018 0:55, Alexander Monakov wrote: > As noted in PR 85354, we cannot simply invoke cfg_cleanup after dominators are > computed, because they may become invalid but neither freed nor recomputed, so > this trips checking in flow_loops_find. > > We can move cleanup_cfg earlier (and run it f

Re: [PATCH] sel-sched: run cleanup_cfg just before loop_optimizer_init (PR 84659)

2018-04-11 Thread Alexander Monakov
As noted in PR 85354, we cannot simply invoke cfg_cleanup after dominators are computed, because they may become invalid but neither freed nor recomputed, so this trips checking in flow_loops_find. We can move cleanup_cfg earlier (and run it for all sel-sched invocations, not only when pipelining)

Re: [PATCH] sel-sched: run cleanup_cfg just before loop_optimizer_init (PR 84659)

2018-04-10 Thread Andrey Belevantsev
Hello, On 10.04.2018 17:40, Alexander Monakov wrote: > Hi, > > We have this code in sel-sched.c sel_region_init(): > > 6918 /* Init correct liveness sets on each instruction of a single-block > loop. > 6919 This is the only situation when we can't update liveness when > calling > 6920

[PATCH] sel-sched: run cleanup_cfg just before loop_optimizer_init (PR 84659)

2018-04-10 Thread Alexander Monakov
Hi, We have this code in sel-sched.c sel_region_init(): 6918 /* Init correct liveness sets on each instruction of a single-block loop. 6919 This is the only situation when we can't update liveness when calling 6920 compute_live for the first insn of the loop. */ 6921 if (current_lo