Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread David Malcolm
On Tue, 2014-08-19 at 11:02 -0700, Richard Henderson wrote: On 08/06/2014 10:19 AM, David Malcolm wrote: @@ -2772,11 +2772,11 @@ mn10300_adjust_sched_cost (rtx insn, rtx link, rtx dep, int cost) if (!TARGET_AM33) return 1; - if (GET_CODE (insn) == PARALLEL) -insn =

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread Richard Henderson
On 08/27/2014 08:48 AM, David Malcolm wrote: Alternatively, should this simply use single_set? Yes. (though I think that's a more invasive change, especially since some of the logic is for non-SETs). I don't think that's the case. Take the tests in order: if (mn10300_tune_cpu ==

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread David Malcolm
On Wed, 2014-08-27 at 09:11 -0700, Richard Henderson wrote: On 08/27/2014 08:48 AM, David Malcolm wrote: Alternatively, should this simply use single_set? Yes. (though I think that's a more invasive change, especially since some of the logic is for non-SETs). I don't think that's

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread Richard Henderson
On 08/27/2014 09:32 AM, David Malcolm wrote: * gcc/config/mn10300/mn10300.c (is_load_insn): Rename to... (set_is_load_p): ...this, updating to work on a SET pattern rather than an insn. (is_store_insn): Rename to... (set_is_store_p): ...this, updating to work on

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:19 AM, David Malcolm wrote: @@ -2772,11 +2772,11 @@ mn10300_adjust_sched_cost (rtx insn, rtx link, rtx dep, int cost) if (!TARGET_AM33) return 1; - if (GET_CODE (insn) == PARALLEL) -insn = XVECEXP (insn, 0, 0); + if (GET_CODE (PATTERN (insn)) == PARALLEL)

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * config/mn10300/mn10300.c (mn10300_adjust_sched_cost): Fix the handling of PARALLEL to work on PATTERN (insn) and PATTERN (dep), rather than just on insn, dep themselves. The latter are insns, and thus can't be

[PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-06 Thread David Malcolm
gcc/ * config/mn10300/mn10300.c (mn10300_adjust_sched_cost): Fix the handling of PARALLEL to work on PATTERN (insn) and PATTERN (dep), rather than just on insn, dep themselves. The latter are insns, and thus can't be PARALLEL. --- gcc/config/mn10300/mn10300.c | 8