Re: [PATCH 007/236] New function: for_each_rtx_in_insn

2014-08-18 Thread David Malcolm
On Tue, 2014-08-12 at 15:08 -0600, Jeff Law wrote: On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (for_each_rtx_in_insn): New function. * rtlanal.c (for_each_rtx_in_insn): Likewise. OK. Note that we're moving away from for_each_rtx... I haven't looked, but there's a

Re: [PATCH 007/236] New function: for_each_rtx_in_insn

2014-08-14 Thread David Malcolm
On Tue, 2014-08-12 at 15:08 -0600, Jeff Law wrote: On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (for_each_rtx_in_insn): New function. * rtlanal.c (for_each_rtx_in_insn): Likewise. OK. Note that we're moving away from for_each_rtx... I haven't looked, but there's a

Re: [PATCH 007/236] New function: for_each_rtx_in_insn

2014-08-14 Thread Richard Sandiford
David Malcolm dmalc...@redhat.com writes: On Tue, 2014-08-12 at 15:08 -0600, Jeff Law wrote: On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (for_each_rtx_in_insn): New function. * rtlanal.c (for_each_rtx_in_insn): Likewise. OK. Note that we're moving away from for_each_rtx...

Re: [PATCH 007/236] New function: for_each_rtx_in_insn

2014-08-14 Thread Jeff Law
On 08/14/14 15:36, Richard Sandiford wrote: Right. I think they're held up on patch 40 (ironically the one that conflicts with yours). I think we could declare side effects in notes as invalid and add some ENABLE_CHECKING bits to enforce that. With those in place, my concerns around #40

Re: [PATCH 007/236] New function: for_each_rtx_in_insn

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (for_each_rtx_in_insn): New function. * rtlanal.c (for_each_rtx_in_insn): Likewise. OK. Note that we're moving away from for_each_rtx... I haven't looked, but there's a reasonable chance we may not need it after Richard

[PATCH 007/236] New function: for_each_rtx_in_insn

2014-08-06 Thread David Malcolm
gcc/ * rtl.h (for_each_rtx_in_insn): New function. * rtlanal.c (for_each_rtx_in_insn): Likewise. --- gcc/rtl.h | 1 + gcc/rtlanal.c | 16 2 files changed, 17 insertions(+) diff --git a/gcc/rtl.h b/gcc/rtl.h index 0858230..3e37ed0 100644 --- a/gcc/rtl.h +++