Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

On Mon, Jul 9, 2018 at 9:05 AM Kugan Vivekanandarajah wrote: > > Hi Richard, > > Thanks for the review. > > On 6 July 2018 at 20:17, Richard Biener wrote: > > On Fri, Jul 6, 2018 at 11:45 AM Kugan Vivekanandarajah > > wrote: > >> > >> Hi Richard, > >> > >> > It was

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

Hi Richard, Thanks for the review. On 6 July 2018 at 20:17, Richard Biener wrote: > On Fri, Jul 6, 2018 at 11:45 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >> > It was rewrite_to_non_trapping_overflow available in tree.h. Thus >> > final value replacement >> > could use that

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

On Fri, Jul 6, 2018 at 11:45 AM Kugan Vivekanandarajah wrote: > > Hi Richard, > > > It was rewrite_to_non_trapping_overflow available in tree.h. Thus > > final value replacement > > could use that before gimplifying instead of using > > rewrite_to_defined_overflow > Thanks. > > Is the attached

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

Hi Richard, > It was rewrite_to_non_trapping_overflow available in tree.h. Thus > final value replacement > could use that before gimplifying instead of using rewrite_to_defined_overflow Thanks. Is the attached patch OK? I am testing this on x86_64-linux-gnu and if there is no new regressions.

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

On Wed, Jun 27, 2018 at 7:00 AM Kugan Vivekanandarajah > > > wrote: > > >> > > >> Hi Richard, > > >> > > >> Thanks for the review. > > >> > > >> On 25 June 2018 at 20:01, Richard Biener > > >>

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

> Hi Richard, > >> > >> Thanks for the review. > >> > >> On 25 June 2018 at 20:01, Richard Biener > >> wrote: > >> > On Fri, Jun 22, 2018 at 11:13 AM Kugan Vivekanandarajah > >> > wrote: > >> >> > >> >>

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

gt;> > On Fri, Jun 22, 2018 at 11:13 AM Kugan Vivekanandarajah >> > wrote: >> >> >> >> [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p >> > >> > This says that COND_EXPR itself isn't expensive. I think we should >>

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

On Wed, Jun 27, 2018 at 7:00 AM Kugan Vivekanandarajah wrote: > > Hi Richard, > > Thanks for the review. > > On 25 June 2018 at 20:01, Richard Biener wrote: > > On Fri, Jun 22, 2018 at 11:13 AM Kugan Vivekanandarajah > > wrote: > >> >

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

Hi Richard, Thanks for the review. On 25 June 2018 at 20:01, Richard Biener wrote: > On Fri, Jun 22, 2018 at 11:13 AM Kugan Vivekanandarajah > wrote: >> >> [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p > > This says that COND_EXPR itself isn't expen

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

On Fri, Jun 22, 2018 at 11:13 AM Kugan Vivekanandarajah wrote: > > [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p This says that COND_EXPR itself isn't expensive. I think we should constrain that a bit. I think a good default would be to only allow a single COND_EXPR whi

[PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

[PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p gcc/ChangeLog: 2018-06-22 Kugan Vivekanandarajah * tree-scalar-evolution.c (expression_expensive_p): Handle COND_EXPR. From aa38b98dd97567c6032c261f19b3705abc2233b0 Mon Sep 17 00:00:00 2001 From: Kugan Vivekanandarajah