Re: PING: Re: [PATCH 18/21] PR jit/63854: Add "long-term" allocator to gcc::context

2015-01-16 Thread Joseph Myers
On Fri, 16 Jan 2015, David Malcolm wrote: > Is the patch acceptable in stage3 (assuming it still > applies/bootstraps/etc)? > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02420.html I have no further comments on the patch. -- Joseph S. Myers jos...@codesourcery.com

PING: Re: [PATCH 18/21] PR jit/63854: Add "long-term" allocator to gcc::context

2015-01-16 Thread David Malcolm
On Wed, 2014-11-19 at 17:36 +, Joseph Myers wrote: > On Wed, 19 Nov 2014, David Malcolm wrote: > > > There's no clean way to release them: retrofitting logic to decide if > > we're dealing with a string literal vs a dynamically-allocated buffer > > (and if something else is pointing to said bu

Re: [PATCH 18/21] PR jit/63854: Add "long-term" allocator to gcc::context

2014-11-19 Thread Joseph Myers
On Wed, 19 Nov 2014, David Malcolm wrote: > There's no clean way to release them: retrofitting logic to decide if > we're dealing with a string literal vs a dynamically-allocated buffer > (and if something else is pointing to said buffer) is messy and > error-prone; they are also unconnected to th

[PATCH 18/21] PR jit/63854: Add "long-term" allocator to gcc::context

2014-11-19 Thread David Malcolm
Some places in the startup code use char * values that can sometimes be string literals, and can sometimes be dynamically built using xstrdup or concat. This isn't a problem for cc1 etc since this is only called once, but for libgccjit they are small per-invocation leaks. There's no clean way to