Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Christophe Lyon
On Tue, 14 Jan 2020 at 14:54, Kyrill Tkachov wrote: > > > On 1/14/20 1:50 PM, Christophe Lyon wrote: > > On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov > > wrote: > >> Hi Christophe, > >> > >> On 12/17/19 3:31 PM, Kyrill Tkachov wrote: > >>> On 12/17/19 2:33 PM, Christophe Lyon wrote: > On

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Kyrill Tkachov
On 1/14/20 1:50 PM, Christophe Lyon wrote: On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov wrote: Hi Christophe, On 12/17/19 3:31 PM, Kyrill Tkachov wrote: On 12/17/19 2:33 PM, Christophe Lyon wrote: On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov wrote: Hi Christophe, On 11/18/19 9:00 AM,

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Christophe Lyon
On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov wrote: > > Hi Christophe, > > On 12/17/19 3:31 PM, Kyrill Tkachov wrote: > > > > On 12/17/19 2:33 PM, Christophe Lyon wrote: > >> On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov > >> wrote: > >>> Hi Christophe, > >>> > >>> On 11/18/19 9:00 AM, Christophe

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-13 Thread Kyrill Tkachov
Hi Christophe, On 12/17/19 3:31 PM, Kyrill Tkachov wrote: On 12/17/19 2:33 PM, Christophe Lyon wrote: On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov wrote: Hi Christophe, On 11/18/19 9:00 AM, Christophe Lyon wrote: On Wed, 13 Nov 2019 at 15:46, Christophe Lyon wrote: On Tue, 12 Nov 2019

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Christophe Lyon
On Tue, 17 Dec 2019 at 16:31, Kyrill Tkachov wrote: > > > On 12/17/19 2:33 PM, Christophe Lyon wrote: > > On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov > > wrote: > >> Hi Christophe, > >> > >> On 11/18/19 9:00 AM, Christophe Lyon wrote: > >>> On Wed, 13 Nov 2019 at 15:46, Christophe Lyon > >>>

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Kyrill Tkachov
On 12/17/19 2:33 PM, Christophe Lyon wrote: On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov wrote: Hi Christophe, On 11/18/19 9:00 AM, Christophe Lyon wrote: On Wed, 13 Nov 2019 at 15:46, Christophe Lyon wrote: On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) wrote: On 18/10/2019

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Christophe Lyon
On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov wrote: > > Hi Christophe, > > On 11/18/19 9:00 AM, Christophe Lyon wrote: > > On Wed, 13 Nov 2019 at 15:46, Christophe Lyon > > wrote: > > > > > > On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) > > > wrote: > > > > > > > > On 18/10/2019

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Kyrill Tkachov
Hi Christophe, On 11/18/19 9:00 AM, Christophe Lyon wrote: On Wed, 13 Nov 2019 at 15:46, Christophe Lyon wrote: > > On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) > wrote: > > > > On 18/10/2019 14:18, Christophe Lyon wrote: > > > +  bool not_supported = arm_arch_notm || flag_pic

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Christophe Lyon
Ping? On Wed, 11 Dec 2019 at 18:19, Christophe Lyon wrote: > > Ping? > > Le jeu. 5 déc. 2019 à 11:13, Christophe Lyon a > écrit : >> >> ping? >> https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01667.html >> >> Kyrill approved the previous version modulo a typo fix, but Richard >> wanted a better

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-11 Thread Christophe Lyon
Ping? Le jeu. 5 déc. 2019 à 11:13, Christophe Lyon a écrit : > ping? > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01667.html > > Kyrill approved the previous version modulo a typo fix, but Richard > wanted a better name for a variable. > Is that version OK? > > Thanks, > > Christophe > > >

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-05 Thread Christophe Lyon
ping? https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01667.html Kyrill approved the previous version modulo a typo fix, but Richard wanted a better name for a variable. Is that version OK? Thanks, Christophe On Tue, 26 Nov 2019 at 16:29, Christophe Lyon wrote: > > ping? > > On Mon, 18 Nov

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-26 Thread Christophe Lyon
ping? On Mon, 18 Nov 2019 at 10:00, Christophe Lyon wrote: > > On Wed, 13 Nov 2019 at 15:46, Christophe Lyon > wrote: > > > > On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) > > wrote: > > > > > > On 18/10/2019 14:18, Christophe Lyon wrote: > > > > + bool not_supported =

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-18 Thread Christophe Lyon
On Wed, 13 Nov 2019 at 15:46, Christophe Lyon wrote: > > On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) > wrote: > > > > On 18/10/2019 14:18, Christophe Lyon wrote: > > > + bool not_supported = arm_arch_notm || flag_pic || TARGET_NEON; > > > > > > > This is a poor name in the

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-13 Thread Christophe Lyon
On Tue, 12 Nov 2019 at 12:17, Richard Earnshaw (lists) wrote: > > On 18/10/2019 14:18, Christophe Lyon wrote: > > +thumb1_gen_const_int (rtx op0, HOST_WIDE_INT op1) > > +{ > > + bool mov_done_p = false; > > + int i; > > + > > + /* Emit upper 3 bytes if needed. */ > > + for (i = 0; i < 3;

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-13 Thread Christophe Lyon
On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) wrote: > > On 18/10/2019 14:18, Christophe Lyon wrote: > > + bool not_supported = arm_arch_notm || flag_pic || TARGET_NEON; > > > > This is a poor name in the context of the function as a whole. What's > not supported. Please think of

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-13 Thread Christophe Lyon
Hi Kyrill, On Tue, 12 Nov 2019 at 11:34, Kyrill Tkachov wrote: > > Hi Christophe, > > On 10/18/19 2:18 PM, Christophe Lyon wrote: > > Hi, > > > > This patch extends support for -mpure-code to all thumb-1 processors, > > by removing the need for MOVT. > > > > Symbol addresses are built using

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-12 Thread Richard Earnshaw (lists)
On 18/10/2019 14:18, Christophe Lyon wrote: +thumb1_gen_const_int (rtx op0, HOST_WIDE_INT op1) +{ + bool mov_done_p = false; + int i; + + /* Emit upper 3 bytes if needed. */ + for (i = 0; i < 3; i++) +{ + int byte = (op1 >> (8 * (3 - i))) & 0xff; + + if (byte) + { +

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-12 Thread Richard Earnshaw (lists)
On 18/10/2019 14:18, Christophe Lyon wrote: + bool not_supported = arm_arch_notm || flag_pic || TARGET_NEON; This is a poor name in the context of the function as a whole. What's not supported. Please think of a better name so that I have some idea what the intention is. R.

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-12 Thread Kyrill Tkachov
Hi Christophe, On 10/18/19 2:18 PM, Christophe Lyon wrote: Hi, This patch extends support for -mpure-code to all thumb-1 processors, by removing the need for MOVT. Symbol addresses are built using upper8_15, upper0_7, lower8_15 and lower0_7 relocations, and constants are built using sequences

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-12 Thread Christophe Lyon
ping^2 ? On Sun, 3 Nov 2019 at 16:07, Christophe Lyon wrote: > > Ping? > > https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01356.html > > On Fri, 18 Oct 2019 at 15:18, Christophe Lyon > wrote: > > > > Hi, > > > > This patch extends support for -mpure-code to all thumb-1 processors, > > by

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-03 Thread Christophe Lyon
Ping? https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01356.html On Fri, 18 Oct 2019 at 15:18, Christophe Lyon wrote: > > Hi, > > This patch extends support for -mpure-code to all thumb-1 processors, > by removing the need for MOVT. > > Symbol addresses are built using upper8_15, upper0_7,

[PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-10-18 Thread Christophe Lyon
b7ad1a31 Mon Sep 17 00:00:00 2001 From: Christophe Lyon Date: Fri, 18 Oct 2019 12:15:12 + Subject: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m) This patch extends support for -mpure-code to all thumb-1 processors, by removing the need for MOVT. Symbol addresses are built