Re: [PATCH 2/2] C: use full locations within c_parser_expr_list's vec

2017-08-23 Thread David Malcolm
On Tue, 2017-08-22 at 13:01 +0200, Andreas Schwab wrote: > On Aug 18 2017, David Malcolm wrote: > > > gcc/c/ChangeLog: > > * c-parser.c (c_parser_expr_list): Use c_expr::get_location () > > rather than peeking the location of the first token. > > * c-tree.h

Re: [PATCH 2/2] C: use full locations within c_parser_expr_list's vec

2017-08-22 Thread Andreas Schwab
On Aug 18 2017, David Malcolm wrote: > gcc/c/ChangeLog: > * c-parser.c (c_parser_expr_list): Use c_expr::get_location () > rather than peeking the location of the first token. > * c-tree.h (c_expr::get_location): New method. This breaks

Re: [PATCH 2/2] C: use full locations within c_parser_expr_list's vec

2017-08-21 Thread Joseph Myers
These two patches are OK. -- Joseph S. Myers jos...@codesourcery.com

[PATCH 2/2] C: use full locations within c_parser_expr_list's vec

2017-08-18 Thread David Malcolm
The previous patch uncovered a bug in how c_parser_expr_list builds the vec: it was only using the location of the first token within each assignment-expression in the expr-list. This shows up in e.g. this -Wformat warning, where only part of the 2nd param is underlined: printf("hello %i",