Re: [PATCH 2/2] rs6000: Update darn testcases

2021-12-17 Thread Bill Schmidt via Gcc-patches
Hi!

On 12/17/21 11:36 AM, Segher Boessenkool wrote:
> Make the darn testcases work (and be tested) in 32-bit mode as well.
> They used to ICE, but they no longer do.
>
>
> 2021-12-17  Segher Boessenkool 
>
> gcc/testsuite/
>   PR target/103624
>   * gcc.target/powerpc/darn-0.c: Remove target clause.
>   * gcc.target/powerpc/darn-1.c: Remove target clause. Remove lp64
>   requirement.  Change return type to long.
>   * gcc.target/powerpc/darn-2.c: Ditto.
>   * gcc.target/powerpc/darn-3.c: Remove target clause.

LGTM.

Thanks!
Bill

>
> ---
>  gcc/testsuite/gcc.target/powerpc/darn-0.c | 2 +-
>  gcc/testsuite/gcc.target/powerpc/darn-1.c | 5 ++---
>  gcc/testsuite/gcc.target/powerpc/darn-2.c | 5 ++---
>  gcc/testsuite/gcc.target/powerpc/darn-3.c | 2 +-
>  4 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-0.c 
> b/gcc/testsuite/gcc.target/powerpc/darn-0.c
> index f446f494b06d..64d98f5f91d7 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-0.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-0.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
>  /* { dg-require-effective-target powerpc_p9vector_ok } */
>  /* { dg-skip-if "" { powerpc*-*-aix* } } */
>  /* { dg-options "-mdejagnu-cpu=power9" } */
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-1.c 
> b/gcc/testsuite/gcc.target/powerpc/darn-1.c
> index 0938718a5ad6..f483a89862d0 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-1.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-1.c
> @@ -1,12 +1,11 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
>  /* { dg-require-effective-target powerpc_p9vector_ok } */
> -/* { dg-require-effective-target lp64 } */
>  /* { dg-skip-if "" { powerpc*-*-aix* } } */
>  /* { dg-options "-mdejagnu-cpu=power9" } */
>  
>  #include 
>  
> -long long get_conditioned_random ()
> +long get_conditioned_random ()
>  {
>return __builtin_darn ();
>  }
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-2.c 
> b/gcc/testsuite/gcc.target/powerpc/darn-2.c
> index 64e44b244c4b..56a9ffb677b4 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-2.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-2.c
> @@ -1,12 +1,11 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
>  /* { dg-require-effective-target powerpc_p9vector_ok } */
> -/* { dg-require-effective-target lp64 } */
>  /* { dg-skip-if "" { powerpc*-*-aix* } } */
>  /* { dg-options "-mdejagnu-cpu=power9" } */
>  
>  #include 
>  
> -long long get_raw_random ()
> +long get_raw_random ()
>  {
>return __builtin_darn_raw ();
>  }
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-3.c 
> b/gcc/testsuite/gcc.target/powerpc/darn-3.c
> index 477901fde70d..4c68fad80d5d 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-3.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-3.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
>  /* { dg-skip-if "" { powerpc*-*-aix* } } */
>  /* { dg-options "-O2 -mdejagnu-cpu=power9" } */
>  


[PATCH 2/2] rs6000: Update darn testcases

2021-12-17 Thread Segher Boessenkool
Make the darn testcases work (and be tested) in 32-bit mode as well.
They used to ICE, but they no longer do.


2021-12-17  Segher Boessenkool 

gcc/testsuite/
PR target/103624
* gcc.target/powerpc/darn-0.c: Remove target clause.
* gcc.target/powerpc/darn-1.c: Remove target clause. Remove lp64
requirement.  Change return type to long.
* gcc.target/powerpc/darn-2.c: Ditto.
* gcc.target/powerpc/darn-3.c: Remove target clause.

---
 gcc/testsuite/gcc.target/powerpc/darn-0.c | 2 +-
 gcc/testsuite/gcc.target/powerpc/darn-1.c | 5 ++---
 gcc/testsuite/gcc.target/powerpc/darn-2.c | 5 ++---
 gcc/testsuite/gcc.target/powerpc/darn-3.c | 2 +-
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/gcc/testsuite/gcc.target/powerpc/darn-0.c 
b/gcc/testsuite/gcc.target/powerpc/darn-0.c
index f446f494b06d..64d98f5f91d7 100644
--- a/gcc/testsuite/gcc.target/powerpc/darn-0.c
+++ b/gcc/testsuite/gcc.target/powerpc/darn-0.c
@@ -1,4 +1,4 @@
-/* { dg-do compile { target { powerpc*-*-* } } } */
+/* { dg-do compile } */
 /* { dg-require-effective-target powerpc_p9vector_ok } */
 /* { dg-skip-if "" { powerpc*-*-aix* } } */
 /* { dg-options "-mdejagnu-cpu=power9" } */
diff --git a/gcc/testsuite/gcc.target/powerpc/darn-1.c 
b/gcc/testsuite/gcc.target/powerpc/darn-1.c
index 0938718a5ad6..f483a89862d0 100644
--- a/gcc/testsuite/gcc.target/powerpc/darn-1.c
+++ b/gcc/testsuite/gcc.target/powerpc/darn-1.c
@@ -1,12 +1,11 @@
-/* { dg-do compile { target { powerpc*-*-* } } } */
+/* { dg-do compile } */
 /* { dg-require-effective-target powerpc_p9vector_ok } */
-/* { dg-require-effective-target lp64 } */
 /* { dg-skip-if "" { powerpc*-*-aix* } } */
 /* { dg-options "-mdejagnu-cpu=power9" } */
 
 #include 
 
-long long get_conditioned_random ()
+long get_conditioned_random ()
 {
   return __builtin_darn ();
 }
diff --git a/gcc/testsuite/gcc.target/powerpc/darn-2.c 
b/gcc/testsuite/gcc.target/powerpc/darn-2.c
index 64e44b244c4b..56a9ffb677b4 100644
--- a/gcc/testsuite/gcc.target/powerpc/darn-2.c
+++ b/gcc/testsuite/gcc.target/powerpc/darn-2.c
@@ -1,12 +1,11 @@
-/* { dg-do compile { target { powerpc*-*-* } } } */
+/* { dg-do compile } */
 /* { dg-require-effective-target powerpc_p9vector_ok } */
-/* { dg-require-effective-target lp64 } */
 /* { dg-skip-if "" { powerpc*-*-aix* } } */
 /* { dg-options "-mdejagnu-cpu=power9" } */
 
 #include 
 
-long long get_raw_random ()
+long get_raw_random ()
 {
   return __builtin_darn_raw ();
 }
diff --git a/gcc/testsuite/gcc.target/powerpc/darn-3.c 
b/gcc/testsuite/gcc.target/powerpc/darn-3.c
index 477901fde70d..4c68fad80d5d 100644
--- a/gcc/testsuite/gcc.target/powerpc/darn-3.c
+++ b/gcc/testsuite/gcc.target/powerpc/darn-3.c
@@ -1,4 +1,4 @@
-/* { dg-do compile { target { powerpc*-*-* } } } */
+/* { dg-do compile } */
 /* { dg-skip-if "" { powerpc*-*-aix* } } */
 /* { dg-options "-O2 -mdejagnu-cpu=power9" } */
 
-- 
1.8.3.1