Re: [PATCH 33/89] Use more concrete types for various gimple statements

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * cgraphunit.c (thunk_adjust): Strengthen local stmt from gimple to gimple_assign. * gimple-ssa-isolate-paths.c (insert_trap_and_remove_trailing_statements): Strengthen local new_stmt from gimple to

[PATCH 33/89] Use more concrete types for various gimple statements

2014-04-21 Thread David Malcolm
gcc/ * cgraphunit.c (thunk_adjust): Strengthen local stmt from gimple to gimple_assign. * gimple-ssa-isolate-paths.c (insert_trap_and_remove_trailing_statements): Strengthen local new_stmt from gimple to gimple_call. *

Re: [PATCH 33/89] Use more concrete types for various gimple statements

2014-04-21 Thread Bill Schmidt
Hi David, Just a quick review of the gimple-ssa-strength-reduction.c changes. I have one stylistic comment: On Mon, 2014-04-21 at 12:57 -0400, David Malcolm wrote: diff --git a/gcc/gimple-ssa-strength-reduction.c b/gcc/gimple-ssa-strength-reduction.c index 9320b51..35e15e0 100644 ---