Re: [PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction

2014-09-08 Thread Christophe Lyon
Hi Alan, In my cross-testing I've noticed that your new test: gcc.target/aarch64/simd/int_comparisons_1.c scan-assembler-not not is PASS for targets aarch64-none-elf and aarch64_be-none-elf, but FAIL for aarch64-none-linux-gnu. It seems this is not what you saw in your own validations?

Re: [PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction

2014-09-08 Thread Alan Lawrence
Hmmm, thanks for the heads-up. Now reproduced. Looks like a TCL regexp issue, should have a fix shortly. Cheers, --Alan Christophe Lyon wrote: Hi Alan, In my cross-testing I've noticed that your new test: gcc.target/aarch64/simd/int_comparisons_1.c scan-assembler-not not is PASS for targets

Re: [PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction

2014-09-02 Thread Marcus Shawcroft
On 19 August 2014 11:44, Alan Lawrence alan.lawre...@arm.com wrote: gcc/ChangeLog: * config/aarch64/aarch64-builtins.c (aarch64_types_cmtst_qualifiers, TYPES_TST): Define. (aarch64_fold_builtin): Update pattern for cmtst. * config/aarch64/aarch64-protos.h

[PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction

2014-08-19 Thread Alan Lawrence
Vector comparisons are sometimes generated with needless 'not' instructions, and 'cmtst' is generally not output at all. This patch makes gen_aarch64_vcond_internal more intelligent with regard to swapping the operands to both the comparison and the conditional move, such that not is avoided