Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-20 Thread Bin.Cheng
On Wed, Nov 18, 2015 at 11:50 PM, Bernd Schmidt wrote: > On 11/10/2015 11:19 AM, Bin.Cheng wrote: >> >> On Tue, Nov 10, 2015 at 6:06 PM, Bernd Schmidt >> wrote: >>> >>> >>> Multi-line expressions should be wrapped in parentheses so that >>> emacs/indent

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-18 Thread Bernd Schmidt
On 11/10/2015 11:19 AM, Bin.Cheng wrote: On Tue, Nov 10, 2015 at 6:06 PM, Bernd Schmidt wrote: Multi-line expressions should be wrapped in parentheses so that emacs/indent can format them automatically. Two sets of parens are needed for this. Operators should then line up

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-10 Thread Bin.Cheng
On Tue, Nov 10, 2015 at 9:26 AM, Bin.Cheng wrote: > On Mon, Nov 9, 2015 at 11:24 PM, Bernd Schmidt wrote: >> On 11/08/2015 10:11 AM, Richard Biener wrote: >>> >>> On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" >>> wrote:

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 09:25 AM, Bin.Cheng wrote: Thanks for reviewing. I haven't committed it yet, could you please point out which quoted piece is so that I can update patch? Sorry, I thought it was pretty obvious... +{ + return ccand1->hash == ccand2->hash +&& operand_equal_p

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-10 Thread Bin.Cheng
On Tue, Nov 10, 2015 at 6:06 PM, Bernd Schmidt wrote: > On 11/10/2015 09:25 AM, Bin.Cheng wrote: >>> >>> Thanks for reviewing. I haven't committed it yet, could you please >>> point out which quoted piece is so that I can update patch? > > > Sorry, I thought it was pretty

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-09 Thread Bernd Schmidt
On 11/08/2015 10:11 AM, Richard Biener wrote: On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" wrote: +inline bool +iv_common_cand_hasher::equal (const iv_common_cand *ccand1, + const iv_common_cand *ccand2) +{ + return ccand1->hash ==

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-09 Thread Bin.Cheng
On Mon, Nov 9, 2015 at 11:24 PM, Bernd Schmidt wrote: > On 11/08/2015 10:11 AM, Richard Biener wrote: >> >> On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" >> wrote: +inline bool +iv_common_cand_hasher::equal (const iv_common_cand

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-08 Thread Richard Biener
On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng" wrote: >On Fri, Nov 6, 2015 at 9:24 PM, Richard Biener > wrote: >> On Wed, Nov 4, 2015 at 11:18 AM, Bin Cheng wrote: >>> Hi, >>> PR52272 reported a performance regression

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-07 Thread Bin.Cheng
On Fri, Nov 6, 2015 at 9:24 PM, Richard Biener wrote: > On Wed, Nov 4, 2015 at 11:18 AM, Bin Cheng wrote: >> Hi, >> PR52272 reported a performance regression in spec2006/410.bwaves once GCC is >> prevented from representing address of one memory

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-06 Thread Richard Biener
On Wed, Nov 4, 2015 at 11:18 AM, Bin Cheng wrote: > Hi, > PR52272 reported a performance regression in spec2006/410.bwaves once GCC is > prevented from representing address of one memory object using address of > another memory object. Also as I commented in that PR, we have

[PATCH PR52272]Be smart when adding iv candidates

2015-11-04 Thread Bin Cheng
Hi, PR52272 reported a performance regression in spec2006/410.bwaves once GCC is prevented from representing address of one memory object using address of another memory object. Also as I commented in that PR, we have two possible fixes for this: 1) Improve how TMR.base is deduced, so that we can