Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-23 Thread Bernd Schmidt
On 10/13/2015 05:17 PM, Pierre-Marie de Rodat wrote: diff --git a/gcc/df-problems.c b/gcc/df-problems.c index c08ae36..56e1cf5 100644 --- a/gcc/df-problems.c +++ b/gcc/df-problems.c @@ -1464,9 +1464,12 @@ df_live_bb_local_compute (unsigned int bb_index) seen are included in the gen

Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-20 Thread Bernd Schmidt
Do you refer to this comment? (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66790#c20) I do have to say that I am still uncomfortable with changing RRE to use a MUST problem rather than a MAY problem. I see this as dumbing down the compiler to provide the semantics of uninitialized variables an

Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-20 Thread Pierre-Marie de Rodat
David, On 10/20/2015 11:17 AM, David Edelsohn wrote: Did this revised patch address the comments about MIR from Kenny? Do you refer to this comment? (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66790#c20) I do have to say that I am still uncomfortable with changing RRE to use a MUST problem

Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-20 Thread David Edelsohn
Pierre, Did this revised patch address the comments about MIR from Kenny? - David

Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-19 Thread Pierre-Marie de Rodat
On 10/14/2015 09:41 AM, Bernd Schmidt wrote: This one is OK with minor changes. I ran some tests with it, and the mir sets look good this time. Code generation still seems unaffected by it on all my example code (which is as expected). Thank you very much for your help on this and for double-ch

Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-14 Thread Bernd Schmidt
On 10/13/2015 05:17 PM, Pierre-Marie de Rodat wrote: The first attached patch is the second attempt to fix PR rtl-optimization/66790 (see ). The second one is a fix for some inconsistency noticed while working on the original bug. This specific

[PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-13 Thread Pierre-Marie de Rodat
Hello, The first attached patch is the second attempt to fix PR rtl-optimization/66790 (see ). The second one is a fix for some inconsistency noticed while working on the original bug. This specific patch fixes no known bug, but anyway… B