Re: [PATCH v2] Re: avoid useless if-before-free tests
Jim Meyering j...@meyering.net writes: I've taken the liberty of letting my editor remove trailing blanks in ChangeLog files. I hope that's ok. Also in ChangeLogs, I converted some leading 8-space (and 7-space) sequences to single TABs. Please move this to a separate patch: this is completely unrelated to the change at hand. And please don't change the alignment of entries with multiple email addresses. I found no ChangeLog for libgo and no other libgo-related entries. I suspect that means I should omit this change because it belongs upstream. Indeed, cf. libgo/README*. I've Cc'ed Ian who maintains this part of GCC. For now, I've added an entry in the top-level ChangeLog file: * libgo/runtime/go-select.c (__go_select): It's easier to remove than to add. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [PATCH v2] Re: avoid useless if-before-free tests
Rainer Orth wrote: Jim Meyering j...@meyering.net writes: the change at hand. And please don't change the alignment of entries with multiple email addresses. Changing 8-spaces to a TAB does not affect alignment when you're looking at the ChangeLog file itself with standard tab setting. Perhaps you looked at a hunk like the following and mistook it for one that introduces an alignment change? 2011-11-04 Eric Botcazou ebotca...@adacore.com -Jakub Jelinek ja...@redhat.com + Jakub Jelinek ja...@redhat.com It does not. I'm pretty sure it does: before, you have 12 SPC, afterwards you have TAB + 3 SPC, which is equivalent to 11 SPC in my book. Here's the precise excerpt from my patch: 2011-11-04 Eric Botcazou ebotca...@adacore.com -Jakub Jelinek ja...@redhat.com + Jakub Jelinek ja...@redhat.com That has TAB + 4, so induced no alignment change. I honestly don't see the point of this whitespace change unless done across all ChangeLogs, not just a few that you happen to touch. As I said, it's gone, now, from my patch. If no one objects, I'll normalize all ChangeLog files.
Re: [PATCH v2] Re: avoid useless if-before-free tests
Jim Meyering j...@meyering.net writes: I honestly don't see the point of this whitespace change unless done across all ChangeLogs, not just a few that you happen to touch. As I said, it's gone, now, from my patch. If no one objects, I'll normalize all ChangeLog files. No objection per se, although it's for the RMs to decide about the timing. If you do, it would be good to fix other issues flagged by Emacs's Change Log mode, like trailing whitespace. Thanks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: [PATCH v2] Re: avoid useless if-before-free tests
On Tue, Mar 08, 2011 at 08:20:22PM +0100, Rainer Orth wrote: Jim Meyering j...@meyering.net writes: I honestly don't see the point of this whitespace change unless done across all ChangeLogs, not just a few that you happen to touch. As I said, it's gone, now, from my patch. If no one objects, I'll normalize all ChangeLog files. No objection per se, although it's for the RMs to decide about the timing. The good timing for the if (x) free (x); patch is right after stage 1 reopens, which will be hopefully RSN. Jakub
