Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-05 Thread Dominik Vogt
On Mon, Dec 05, 2016 at 07:56:46AM -0600, Segher Boessenkool wrote: > On Mon, Dec 05, 2016 at 10:22:13AM +0100, Dominik Vogt wrote: > > Sorry for breaking this. With the constant changes in the > > patterns this is supposed to fix it seems I've lost track of the > > status quo. I'll check what

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-05 Thread Segher Boessenkool
On Mon, Dec 05, 2016 at 10:22:13AM +0100, Dominik Vogt wrote: > Sorry for breaking this. With the constant changes in the > patterns this is supposed to fix it seems I've lost track of the > status quo. I'll check what went wrong with the patch; in the > mean time Andreas will revert this, or if

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-05 Thread Oleg Endo
On Mon, 2016-12-05 at 04:00 -0600, Segher Boessenkool wrote: > On Mon, Dec 05, 2016 at 10:22:13AM +0100, Dominik Vogt wrote: > > > > On Sat, Dec 03, 2016 at 07:19:13PM -0600, Segher Boessenkool wrote: > > > > > > [ I did not see this patch before, sorry. ] > > > > > > This causes the second

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-05 Thread Dominik Vogt
On Mon, Dec 05, 2016 at 04:00:25AM -0600, Segher Boessenkool wrote: > On Mon, Dec 05, 2016 at 10:22:13AM +0100, Dominik Vogt wrote: > > On Sat, Dec 03, 2016 at 07:19:13PM -0600, Segher Boessenkool wrote: > > > [ I did not see this patch before, sorry. ] > > > > > > This causes the second half of

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-05 Thread Segher Boessenkool
On Mon, Dec 05, 2016 at 10:22:13AM +0100, Dominik Vogt wrote: > On Sat, Dec 03, 2016 at 07:19:13PM -0600, Segher Boessenkool wrote: > > [ I did not see this patch before, sorry. ] > > > > This causes the second half of PR78638. > > > > On Thu, Dec 01, 2016 at 04:30:08PM +0100, Dominik Vogt

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-05 Thread Dominik Vogt
On Sat, Dec 03, 2016 at 07:19:13PM -0600, Segher Boessenkool wrote: > [ I did not see this patch before, sorry. ] > > This causes the second half of PR78638. > > On Thu, Dec 01, 2016 at 04:30:08PM +0100, Dominik Vogt wrote: > > --- a/gcc/combine.c > > +++ b/gcc/combine.c > > @@ -5600,6 +5600,18

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-03 Thread Segher Boessenkool
[ I did not see this patch before, sorry. ] This causes the second half of PR78638. On Thu, Dec 01, 2016 at 04:30:08PM +0100, Dominik Vogt wrote: > --- a/gcc/combine.c > +++ b/gcc/combine.c > @@ -5600,6 +5600,18 @@ combine_simplify_rtx (rtx x, machine_mode op0_mode, > int in_dest, >

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-03 Thread Andreas Schwab
On Dez 01 2016, Dominik Vogt wrote: > gcc/ChangeLog > > * combine.c (combine_simplify_rtx): Suppress replacement of > "(and (reg) (const_int bit))" with "if_then_else". That causes a regression on ia64. FAIL: gcc.target/ia64/builtin-popcount-2.c

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-02 Thread Andreas Krebbel
On Thu, Dec 01, 2016 at 04:30:08PM +0100, Dominik Vogt wrote: > gcc/ChangeLog > > * combine.c (combine_simplify_rtx): Suppress replacement of > "(and (reg) (const_int bit))" with "if_then_else". Applied. Thanks! -Andreas-

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

2016-12-01 Thread Dominik Vogt
On Thu, Dec 01, 2016 at 01:33:17PM +0100, Bernd Schmidt wrote: > On 11/21/2016 01:36 PM, Dominik Vogt wrote: > >diff --git a/gcc/combine.c b/gcc/combine.c > >index b22a274..457fe8a 100644 > >--- a/gcc/combine.c > >+++ b/gcc/combine.c > >@@ -5575,10 +5575,23 @@ combine_simplify_rtx (rtx x,