Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-06 Thread Richard Earnshaw (lists)
On 06/09/2019 11:15, Bernd Edlinger wrote: On 9/4/19 2:53 PM, Richard Earnshaw (lists) wrote: Index: gcc/testsuite/gcc.target/arm/unaligned-argument-2.c === --- gcc/testsuite/gcc.target/arm/unaligned-argument-2.c    (Revision 0) +++

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-06 Thread Bernd Edlinger
On 9/4/19 2:53 PM, Richard Earnshaw (lists) wrote: > Index: gcc/testsuite/gcc.target/arm/unaligned-argument-2.c > === > --- gcc/testsuite/gcc.target/arm/unaligned-argument-2.c    (Revision 0) > +++ gcc/testsuite/gcc.target/arm/unaligne

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-05 Thread Bernd Edlinger
On 9/5/19 11:21 AM, Richard Earnshaw (lists) wrote: > On 04/09/2019 16:48, Richard Earnshaw (lists) wrote: >> On 04/09/2019 16:00, Bernd Edlinger wrote: >>> On 9/4/19 4:14 PM, Richard Earnshaw (lists) wrote: On 04/09/2019 14:28, Bernd Edlinger wrote: > On 9/4/19 2:53 PM, Richard Earnshaw (

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-05 Thread Richard Earnshaw (lists)
On 04/09/2019 16:48, Richard Earnshaw (lists) wrote: On 04/09/2019 16:00, Bernd Edlinger wrote: On 9/4/19 4:14 PM, Richard Earnshaw (lists) wrote: On 04/09/2019 14:28, Bernd Edlinger wrote: On 9/4/19 2:53 PM, Richard Earnshaw (lists) wrote: Index: gcc/testsuite/gcc.target/arm/unaligned-argume

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-04 Thread Richard Earnshaw (lists)
On 04/09/2019 16:00, Bernd Edlinger wrote: On 9/4/19 4:14 PM, Richard Earnshaw (lists) wrote: On 04/09/2019 14:28, Bernd Edlinger wrote: On 9/4/19 2:53 PM, Richard Earnshaw (lists) wrote: Index: gcc/testsuite/gcc.target/arm/unaligned-argument-2.c ===

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-04 Thread Bernd Edlinger
On 9/4/19 4:14 PM, Richard Earnshaw (lists) wrote: > On 04/09/2019 14:28, Bernd Edlinger wrote: >> On 9/4/19 2:53 PM, Richard Earnshaw (lists) wrote: >>> Index: gcc/testsuite/gcc.target/arm/unaligned-argument-2.c >>> === >>> --- gcc/te

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-04 Thread Richard Earnshaw (lists)
On 04/09/2019 14:28, Bernd Edlinger wrote: On 9/4/19 2:53 PM, Richard Earnshaw (lists) wrote: On 15/08/2019 20:47, Bernd Edlinger wrote: On 8/15/19 6:29 PM, Richard Biener wrote: Please split it into the parts for the PR and parts making the asserts not trigger. Yes, will do. Okay, here

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-04 Thread Bernd Edlinger
On 9/4/19 2:53 PM, Richard Earnshaw (lists) wrote: > On 15/08/2019 20:47, Bernd Edlinger wrote: >> On 8/15/19 6:29 PM, Richard Biener wrote: > > Please split it into the parts for the PR and parts making the > asserts not trigger. > Yes, will do. >> >> Okay, here is t

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-09-04 Thread Richard Earnshaw (lists)
On 15/08/2019 20:47, Bernd Edlinger wrote: On 8/15/19 6:29 PM, Richard Biener wrote: Please split it into the parts for the PR and parts making the asserts not trigger. Yes, will do. Okay, here is the rest of the PR 89544 fix, actually just an optimization, making the larger stack alignme

Re: Fwd: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-20 Thread Bernd Edlinger
Ah, yes that was unexpected... Sorry for the breakage. So this needs to be known_eq (STACK_POINTER_OFFSET, 0) instead of STACK_POINTER_OFFSET == 0 obviously. Should be fixed by this patch, which I am going to commit as "obvious" in a moment unless someone objects. Thanks Bernd. On 8/20/19 4:3

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-20 Thread John David Anglin
On 2019-08-15 3:47 p.m., Bernd Edlinger wrote: > 2019-08-15 Bernd Edlinger > > PR middle-end/89544 > * function.c (assign_parm_find_stack_rtl): Use larger alignment > when possible. This patch breaks build on hppa-unknown-linux-gnu: https://buildd.debian.org/status/fetch.php?pk

Re: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-19 Thread Jeff Law
On 8/15/19 1:47 PM, Bernd Edlinger wrote: > On 8/15/19 6:29 PM, Richard Biener wrote: Please split it into the parts for the PR and parts making the asserts not trigger. >>> Yes, will do. >>> > Okay, here is the rest of the PR 89544 fix, > actually just an optimization, making the la

[PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-15 Thread Bernd Edlinger
On 8/15/19 6:29 PM, Richard Biener wrote: >>> >>> Please split it into the parts for the PR and parts making the >>> asserts not trigger. >>> >> >> Yes, will do. >> Okay, here is the rest of the PR 89544 fix, actually just an optimization, making the larger stack alignment known to the middle-end,