On 14 Jul, Martin Sebor wrote:
> On 06/21/2017 01:59 AM, Volker Reichelt wrote:
>> On 20 Jun, Jason Merrill wrote:
>>> On Tue, Jun 20, 2017 at 3:06 PM, David Malcolm wrote:
It's not clear to me what the issue alluded to with negative
obstack_blank is, but I chose to
On 06/21/2017 01:59 AM, Volker Reichelt wrote:
On 20 Jun, Jason Merrill wrote:
On Tue, Jun 20, 2017 at 3:06 PM, David Malcolm wrote:
It's not clear to me what the issue alluded to with negative
obstack_blank is, but I chose to follow the above docs and use
On 20 Jun, Jason Merrill wrote:
> On Tue, Jun 20, 2017 at 3:06 PM, David Malcolm wrote:
>> It's not clear to me what the issue alluded to with negative
>> obstack_blank is, but I chose to follow the above docs and use
>> obstack_blank_fast; am testing an updated patch in
On Tue, Jun 20, 2017 at 3:06 PM, David Malcolm wrote:
> It's not clear to me what the issue alluded to with negative
> obstack_blank is, but I chose to follow the above docs and use
> obstack_blank_fast; am testing an updated patch in which the above line
> now looks like:
>
On Tue, 2017-06-20 at 14:01 -0400, Jason Merrill wrote:
> On Tue, Jun 20, 2017 at 1:58 PM, Jason Merrill
> wrote:
> > On Tue, Jun 20, 2017 at 11:50 AM, David Malcolm <
> > dmalc...@redhat.com> wrote:
> > > > + ob->next_free = p + type_start + type_len;
> >
> > I'm
On Tue, Jun 20, 2017 at 1:58 PM, Jason Merrill wrote:
> On Tue, Jun 20, 2017 at 11:50 AM, David Malcolm wrote:
>>> + ob->next_free = p + type_start + type_len;
>
> I'm uncomfortable with modifying the obstack directly. Why not use
> obstack_free?
On Tue, Jun 20, 2017 at 11:50 AM, David Malcolm wrote:
>> + ob->next_free = p + type_start + type_len;
I'm uncomfortable with modifying the obstack directly. Why not use
obstack_free? I guess for that you'd want to change type_start to a
pointer and get it from
Ping re the C++ part of this:
https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00242.html
Marek approved the C parts; are the C++ parts OK for trunk?
Or can I self-approve this? (exactly what the boundaries of
my"diagnostic messages" maintainer remit are aren't clear to me).
Thanks
Dave
On