Re: [PING] Re: [PATCH v2] Re: [WIP] Have -Wpointer-sign be enabled by -Wextra, too [PR109836]
On Wed, 16 Aug 2023, Eric Gallager via Gcc-patches wrote:
> PING
>
> On Tue, Aug 8, 2023 at 8:17 PM Eric Gallager wrote:
> >
> > On Tue, May 30, 2023 at 5:42 PM Eric Gallager wrote:
> > >
> > > PR109836 is a request to have -Wpointer-sign enabled by default. There
> > > were points of disagreement raised in the bug report, so I figured
> > > that maybe as a compromise, the warning could just be enabled by
> > > -Wextra, as well (I have in fact seen some projects that enable
> > > -Wextra but not -Wall). This patch would implement my suggestion of
> > > adding it to -Wextra, but it's not ready to commit yet, as it still
> > > needs testing, documentation, and a ChangeLog entry. I'm just posting
> > > it here as an RFC; what do people think?
The documentation for -Wextra says "This enables some extra warning flags
that are not enabled by @option{-Wall}." (and this patch doesn't change
that documentation). I don't see any coherent reason for changing that to
add a single one of the -Wall warnings (but not any of the others). (I'm
*not* suggesting making -Wextra a superset of -Wall, but I don't think
this change is a sensible one.)
--
Joseph S. Myers
jos...@codesourcery.com
[PING] Re: [PATCH v2] Re: [WIP] Have -Wpointer-sign be enabled by -Wextra, too [PR109836]
PING On Tue, Aug 8, 2023 at 8:17 PM Eric Gallager wrote: > > On Tue, May 30, 2023 at 5:42 PM Eric Gallager wrote: > > > > PR109836 is a request to have -Wpointer-sign enabled by default. There > > were points of disagreement raised in the bug report, so I figured > > that maybe as a compromise, the warning could just be enabled by > > -Wextra, as well (I have in fact seen some projects that enable > > -Wextra but not -Wall). This patch would implement my suggestion of > > adding it to -Wextra, but it's not ready to commit yet, as it still > > needs testing, documentation, and a ChangeLog entry. I'm just posting > > it here as an RFC; what do people think? > > Here's the link for the previous message's spot in the archives: > https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620137.html > Here's an updated (but still untested) version of the patch with an > invoke.texi > update and a ChangeLog entry: > > gcc/c-family/ChangeLog: > > * c.opt: Have -Wpointer-sign be enabled by -Wextra, too > > gcc/ChangeLog: > > * doc/invoke.texi: Document -Wpointer-sign now being enabled by -Wextra, > too
