Re: [Patch, Fortran] Add stat=/errmsg= support to _gfortran_caf_register

2011-07-08 Thread Janne Blomqvist
On Thu, Jul 7, 2011 at 15:48, Tobias Burnus bur...@net-b.de wrote: I have now committed the patch with only the nits fixed (Rev.175966). But given that the coarray support - especially with regards to the library - is still in a flux, we can still change everything, including the ABI of the

Re: [Patch, Fortran] Add stat=/errmsg= support to _gfortran_caf_register

2011-07-07 Thread Mikael Morin
On Thursday 07 July 2011 07:35:07 Tobias Burnus wrote: diff --git a/libgfortran/caf/mpi.c b/libgfortran/caf/mpi.c index 83f39f6..2d4af6b 100644 --- a/libgfortran/caf/mpi.c +++ b/libgfortran/caf/mpi.c @@ -103,10 +110,19 @@ _gfortran_caf_register (ptrdiff_t size, caf_register_t type, /*

Re: [Patch, Fortran] Add stat=/errmsg= support to _gfortran_caf_register

2011-07-07 Thread Tobias Burnus
On 07/07/2011 01:35 PM, Mikael Morin wrote: if (type == CAF_REGTYPE_COARRAY_STATIC) { This will return the same error (memory allocation failure) as in the case just above. Is this expected or should it have an error of its own? I think it is OK in either case.

[Patch, Fortran] Add stat=/errmsg= support to _gfortran_caf_register

2011-07-06 Thread Tobias Burnus
This patch cleans up the ABI mess, I created at some point. The initial version of _gfortran_caf_register didn't handle stat/errmsg as one could leave it to the front end: The the returned memory is NULL, it's an error. However, as Nick pointed out, for stat= one can also return