Re: [Patch, Fortran] PRs 61881/61888 - Fix issues with SIZEOF, CLASS(*) and assumed-rank

2014-09-03 Thread Tobias Burnus
Thomas Schwinge wrote: On Sat, 26 Jul 2014 01:47:02 +0200, Tobias Burnus bur...@net-b.de wrote: [...] 2014-07-26 Tobias Burnus bur...@net-b.de * gfortran.dg/sizeof_4.f90: New. [...] I noticed that the sizeof_4.f90 test case has not been checked in, probably just forgot to svn add

Re: [Patch, Fortran] PRs 61881/61888 - Fix issues with SIZEOF, CLASS(*) and assumed-rank

2014-09-02 Thread Thomas Schwinge
Hi Tobias! On Sat, 26 Jul 2014 01:47:02 +0200, Tobias Burnus bur...@net-b.de wrote: 2014-07-26 Tobias Burnus bur...@net-b.de * check.c (gfc_check_sizeof): Permit for assumed type if and only if it has an array descriptor. * intrinsic.c (do_ts29113_check): Permit SIZEOF.

Re: [Patch, Fortran] PRs 61881/61888 - Fix issues with SIZEOF, CLASS(*) and assumed-rank

2014-07-26 Thread Paul Richard Thomas
Dear Tobias, Whilst I am aware that we can now use the single line C++ comment, would it perhaps be a better idea to stick with the C style comments just for uniformity? + if (arg-ts.type == BT_CLASS) +{ + tmp = gfc_vtable_size_get (TREE_OPERAND (argse.expr, 0)); + tmp =

Re: [Patch, Fortran] PRs 61881/61888 - Fix issues with SIZEOF, CLASS(*) and assumed-rank

2014-07-26 Thread Tobias Burnus
Dear Paul, Paul Richard Thomas wrote: Whilst I am aware that we can now use the single line C++ comment, would it perhaps be a better idea to stick with the C style comments just for uniformity? Okay. + if (arg-ts.type == BT_CLASS) +{ + tmp = gfc_vtable_size_get (TREE_OPERAND

Re: [Patch, Fortran] PRs 61881/61888 - Fix issues with SIZEOF, CLASS(*) and assumed-rank

2014-07-26 Thread Tobias Burnus
Tobias Burnus wrote: Assuming that the second part is okay, I have now committed it with the comment-style change as Rev. 213079. Dominique has pointed out (thanks!) that the patch fixed PR57305 - and reading that PR, I saw that I missed the declared - dynamic type change. Hence, I have

[Patch, Fortran] PRs 61881/61888 - Fix issues with SIZEOF, CLASS(*) and assumed-rank

2014-07-25 Thread Tobias Burnus
The patch has been motivated by the needs for implementing the openacc module. In particular, it does: - Fix passing intrinsic types to CLASS(*) [F2003] - Fix STORAGE_SIZE for polymorphic arrays [F2003] - Permit the vendor intrinsic SIZEOF also for TYPE(*) if and only if an array descriptor