Re: [Patch, fortran, 5] Bakport Andre's r222477 deep copy fix for PR67818

Le 15/10/2015 12:18, Andre Vehreschild a écrit : Hi Mikael, hi all, I have checked that the patch (my initial one for pr59678) does compile and test fine. Given that the patch lives in trunk-6 for quite some time now, without any major complaints, I approve to commit to gcc-5. Thanks, I'll

Re: [Patch, fortran, 5] Bakport Andre's r222477 deep copy fix for PR67818

Hi Mikael, hi all, I have checked that the patch (my initial one for pr59678) does compile and test fine. Given that the patch lives in trunk-6 for quite some time now, without any major complaints, I approve to commit to gcc-5. Given the patch was reviewed by Paul already, I don't see any reason

Re: [Patch, fortran, 5] Bakport Andre's r222477 deep copy fix for PR67818

> In other words, > consider youself a reviewer for patches in an area > of the compiler that you are comfortable. Seconded. FX

Re: [Patch, fortran, 5] Bakport Andre's r222477 deep copy fix for PR67818

On Thu, Oct 15, 2015 at 12:18:12PM +0200, Andre Vehreschild wrote: > > Regards, > Andre > > PS: Note, I don't have reviewer status. > Given your contributions to gfortran and the fact that you probably understand portions of the (de)allocation code better than anyone, I suspect that your

Re: [Patch, fortran, 5] Bakport Andre's r222477 deep copy fix for PR67818

> Le 15 oct. 2015 à 16:59, FX a écrit : > >> In other words, >> consider youself a reviewer for patches in an area >> of the compiler that you are comfortable. > > Seconded. > > FX Agreed, Dominique

Re: [Patch, fortran, 5] Bakport Andre's r222477 deep copy fix for PR67818

Me too! Paul On 15 October 2015 at 18:31, Dominique d'Humières wrote: > >> Le 15 oct. 2015 à 16:59, FX a écrit : >> >>> In other words, >>> consider youself a reviewer for patches in an area >>> of the compiler that you are comfortable. >> >> Seconded.

[Patch, fortran, 5] Bakport Andre's r222477 deep copy fix for PR67818

Hello, my recent PR67721 patch [1] introduced a regression [2] on the 5 branch. [1] https://gcc.gnu.org/ml/gcc-patches/2015-09/msg02048.html [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67818 The patch [1] introduces more deep copies, but deep copies have been somewhat broken, until Andre