Re: [Patch] Patch set for regex instantiation

2014-06-29 Thread Jonathan Wakely
On 11/01/14 19:48 -0500, Tim Shen wrote: Here're 4 patches that finally led the _Compiler's instantiation and some other optimization for compiling time. 1) Create class _ScannerBase to make _Scanner pithier. Move const static members to src/c++11/regex.cc. I think it might be time to revisit

Re: [Patch] Patch set for regex instantiation

2014-06-29 Thread Tim Shen
On Sun, Jun 29, 2014 at 10:18 AM, Jonathan Wakely jwak...@redhat.com wrote: Alternatively, we could just make them local statics instead of member data and still remove the duplciation (see attached). This is a good idea. Can we use constexpr for the functions/static variables? -- Regards,

Re: [Patch] Patch set for regex instantiation

2014-06-29 Thread Daniel Krügler
2014-06-29 20:47 GMT+02:00 Tim Shen timshe...@gmail.com: On Sun, Jun 29, 2014 at 10:18 AM, Jonathan Wakely jwak...@redhat.com wrote: Alternatively, we could just make them local statics instead of member data and still remove the duplciation (see attached). This is a good idea. Can we use

Re: [Patch] Patch set for regex instantiation

2014-01-12 Thread Paolo Carlini
Hi On 12/gen/2014, at 01:48, Tim Shen timshe...@gmail.com wrote: Here're 4 patches that finally led the _Compiler's instantiation and some other optimization for compiling time. 1) Create class _ScannerBase to make _Scanner pithier. Move const static members to src/c++11/regex.cc. 2)