Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-25 Thread Bruce Korb
On 06/24/12 15:54, rbmj wrote: + c_fix_arg = "%0\n" + "#ifdef IN_GCC\n" + "#define mkdir(dir, mode) ((mode), (mkdir)(dir))\n" + "#endif\n"; + c_fix_arg = "extern[\t ]+STATUS[\t ]+mkdir[\t ]*" + "\\([\t

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-24 Thread rbmj
On 06/22/2012 06:52 PM, rbmj wrote: On 06/11/2012 08:01 AM, Paolo Bonzini wrote: Il 11/06/2012 13:56, rbmj ha scritto: 1. VxWorks does not have a variadic open - it must receive three arguments. gcc/gcov.c however opens a file for reading and does not pass in a mode argument, which causes an

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-22 Thread rbmj
On 06/11/2012 08:01 AM, Paolo Bonzini wrote: Il 11/06/2012 13:56, rbmj ha scritto: 1. VxWorks does not have a variadic open - it must receive three arguments. gcc/gcov.c however opens a file for reading and does not pass in a mode argument, which causes an error on vxWorks. This just adds a p

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-22 Thread rbmj
On 06/21/2012 09:40 PM, Hans-Peter Nilsson wrote: On Wed, 20 Jun 2012, rbmj wrote: There is an alternate solution- I could use fixincludes to add a macro to wrap over mkdir on VxWorks. A couple of possible ways to do this: 1. Define a normal macro to posix-ify it, i.e. #define mkdir(a, b) ((m

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-21 Thread Hans-Peter Nilsson
On Wed, 20 Jun 2012, rbmj wrote: > There is an alternate solution- I could use fixincludes to add a macro to wrap > over mkdir on VxWorks. A couple of possible ways to do this: > > 1. Define a normal macro to posix-ify it, i.e. #define mkdir(a, b) > ((mkdir)(a)). Since this would hide single-arg

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-20 Thread rbmj
On 06/12/2012 08:16 AM, rbmj wrote: On 06/11/2012 08:01 AM, Paolo Bonzini wrote: VxWorks should define TARGET_POSIX_IO if it has both access and mkdir. Please add it to gcc/config/vxworks.h if this is the case. I misspoke in my earlier email - sorry for my lack of attention to detail. The is

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-12 Thread rbmj
On 06/11/2012 08:01 AM, Paolo Bonzini wrote: Il 11/06/2012 13:56, rbmj ha scritto: ... simply pass the extra mode argument in unconditionally, as it should be transparent to the function and ignored if it is variadic (I'm no expert on calling conventions though). Yes, please do this. Done. VxW

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-11 Thread Paolo Bonzini
Il 11/06/2012 13:56, rbmj ha scritto: >>> 1. VxWorks does not have a variadic open - it must receive three >>> arguments. gcc/gcov.c however opens a file for reading and does not >>> pass in a mode argument, which causes an error on vxWorks. This just >>> adds a platform-based ifdef around this.

[Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-11 Thread rbmj
Hi everyone, Ping RE: http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00086.html Thanks, Robert Mason On 06/01/2012 02:43 PM, rbmj wrote: On 06/01/2012 02:40 PM, rbmj wrote: Hi everyone, These fixes are to allow building on vxWorks. Currently there are two issues: 1. VxWorks does not have