Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-12-04 Thread GT via Gcc-patches
‐‐‐ Original Message ‐‐‐ On Thursday, August 20, 2020 1:48 PM, Segher Boessenkool wrote: > On Thu, Aug 20, 2020 at 04:19:36PM +, GT wrote: > > > > Great! Please repost with what I already pointed out fixed, that > > > explanation added, and working links to the documentation? > > >

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-20 Thread Segher Boessenkool
On Thu, Aug 20, 2020 at 07:31:50PM +, GT wrote: > I'm still trying to understand why we need attribute((target("vsx"))). You need Power8, even! "vsx" alone is not enough (that only guarantees Power7). Your minimum version ("b") requires Power8. Segher

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-20 Thread Jakub Jelinek via Gcc-patches
On Thu, Aug 20, 2020 at 07:31:50PM +, GT wrote: > I'm still trying to understand why we need attribute((target("vsx"))). > > https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes > > The documentation for target(string) states that the purpose is to

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-20 Thread GT via Gcc-patches
‐‐‐ Original Message ‐‐‐ On Thursday, August 13, 2020 5:00 PM, Jakub Jelinek wrote: > On Thu, Aug 13, 2020 at 08:40:22PM +, GT wrote: > > > I'm looking at ix86_simd_clone_adjust and also aarch64_simd_clone_adjust. > > The latter is > > much simpler and I see how I would add PPC

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-20 Thread Segher Boessenkool
On Thu, Aug 20, 2020 at 04:19:36PM +, GT wrote: > > Great! Please repost with what I already pointed out fixed, that > > explanation added, and working links to the documentation? > > Are you ok with the titles of the patch and this document? > >

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-20 Thread GT via Gcc-patches
‐‐‐ Original Message ‐‐‐ On Tuesday, August 18, 2020 5:32 PM, Segher Boessenkool wrote: > On Tue, Aug 18, 2020 at 07:14:19PM +, GT wrote: > > > > That sounds like libmvec? > > > I still don't know what this is. > > > > Yes, it is libmvec. > > Now look at what GCC does to the code in

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-18 Thread Segher Boessenkool
On Tue, Aug 18, 2020 at 07:14:19PM +, GT wrote: > > That sounds like libmvec? > > > > I still don't know what this is. > > Yes, it is libmvec. > > Now look at what GCC does to the code in Examples 1 and 2 at this link: > https://sourceware.org/glibc/wiki/libmvec > > x86_64 added

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-18 Thread GT via Gcc-patches
‐‐‐ Original Message ‐‐‐ On Monday, August 17, 2020 5:28 PM, Segher Boessenkool wrote: > On Mon, Aug 17, 2020 at 05:44:46PM +, GT wrote: > > > > This is about the Power binding to some OpenMP API, right? It has > > > nothing to do with "vector" or "ABI" -- we have vectors already,

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-17 Thread Segher Boessenkool
On Mon, Aug 17, 2020 at 06:05:09PM -0400, David Edelsohn wrote: > The Power Vector ABI is available at > > https://github.com/power8-abi-doc/vector-function-abi > > It apparently did not attach correctly to the sourceware wiki or the > filename is different. Thanks! Segher

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-17 Thread David Edelsohn via Gcc-patches
The Power Vector ABI is available at https://github.com/power8-abi-doc/vector-function-abi It apparently did not attach correctly to the sourceware wiki or the filename is different. Thanks, David On Mon, Aug 17, 2020 at 1:44 PM GT wrote: > > ‐‐‐ Original Message ‐‐‐ > On Thursday,

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-17 Thread Segher Boessenkool
On Mon, Aug 17, 2020 at 05:44:46PM +, GT wrote: > > This is about the Power binding to some OpenMP API, right? It has > > nothing to do with "vector" or "ABI" -- we have vectors already, and > > we have ABIs already, more than enough of each. > > > > It is very very VERY hard to review this

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-17 Thread GT via Gcc-patches
‐‐‐ Original Message ‐‐‐ On Thursday, August 13, 2020 6:49 PM, Segher Boessenkool wrote: > Hi! > > This is about the Power binding to some OpenMP API, right? It has > nothing to do with "vector" or "ABI" -- we have vectors already, and > we have ABIs already, more than enough of each. >

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-13 Thread Segher Boessenkool
Hi! This is about the Power binding to some OpenMP API, right? It has nothing to do with "vector" or "ABI" -- we have vectors already, and we have ABIs already, more than enough of each. It is very very VERY hard to review this without being told the proper setting here. On Fri, Aug 07, 2020

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-13 Thread Jakub Jelinek via Gcc-patches
On Thu, Aug 13, 2020 at 08:40:22PM +, GT wrote: > I'm looking at ix86_simd_clone_adjust and also aarch64_simd_clone_adjust. The > latter is > much simpler and I see how I would add PPC attribute "vsx" similarly. If I > was to follow > the ix86_simd_clone_adjust organization, then

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-13 Thread GT via Gcc-patches
‐‐‐ Original Message ‐‐‐ On Monday, August 10, 2020 2:07 PM, Jakub Jelinek wrote: > On Mon, Aug 10, 2020 at 05:29:49PM +, GT wrote: > > > > For PowerPC, if all you want to support is b which requires VSX, then the > > > right thing is for !TREE_PUBLIC functions return 0 if

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-10 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 10, 2020 at 05:29:49PM +, GT wrote: > > For PowerPC, if all you want to support is b which requires VSX, then the > > right thing is for !TREE_PUBLIC functions return 0 if !TARGET_VSX and > > otherwise set vecsize_mangle to 'b' and in the end return 1, for exported > > functions

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-10 Thread GT via Gcc-patches
‐‐‐ Original Message ‐‐‐ On Friday, August 7, 2020 4:59 PM, Jakub Jelinek wrote: > On Fri, Aug 07, 2020 at 08:35:52PM +, Bert Tenjy via Gcc-patches wrote: > > > The document describing POWER Architecture Vector Function interface is > > tentatively at: > >

Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-07 Thread Jakub Jelinek via Gcc-patches
On Fri, Aug 07, 2020 at 08:35:52PM +, Bert Tenjy via Gcc-patches wrote: > The document describing POWER Architecture Vector Function interface is > tentatively at: > https://sourceware.org/glibc/wiki/Homepage?action=AttachFile=view=powerarchvectfuncabi.html Doesn't exist. > + if

[RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.

2020-08-07 Thread Bert Tenjy via Gcc-patches
From: Bert Tenjy This patch adds functionality to enable use of POWER Architecture's VSX extensions to speed up certain code sequences. Typically 2 or 4 consecutive loop iterations that each make a single scalar function call will be combined into one iteration making a single vector function