Re: [aarch64] Code-gen for vector initialization involving constants

On Wed, 31 May 2023 at 00:23, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi Richard, > > The s32 case for single constant patch doesn't regress now after the > > above commit. > > Bootstrapped+tested on aarch64-linux-gnu, and verified that the new > > tests pass for

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > Hi Richard, > The s32 case for single constant patch doesn't regress now after the > above commit. > Bootstrapped+tested on aarch64-linux-gnu, and verified that the new > tests pass for aarch64_be-linux-gnu. > Is it OK to commit ? > > Thanks, > Prathamesh > >

Re: [aarch64] Code-gen for vector initialization involving constants

On Thu, 25 May 2023 at 15:26, Prathamesh Kulkarni wrote: > > On Thu, 25 May 2023 at 13:04, Richard Sandiford > wrote: > > > > LGTM, just a couple of comment tweaks: > > > > Prathamesh Kulkarni writes: > > > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > > > index

Re: [aarch64] Code-gen for vector initialization involving constants

On Thu, 25 May 2023 at 13:04, Richard Sandiford wrote: > > LGTM, just a couple of comment tweaks: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > > index d6fc94015fa..db7ca4c28c3 100644 > > --- a/gcc/config/aarch64/aarch64.cc > >

Re: [aarch64] Code-gen for vector initialization involving constants

LGTM, just a couple of comment tweaks: Prathamesh Kulkarni writes: > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > index d6fc94015fa..db7ca4c28c3 100644 > --- a/gcc/config/aarch64/aarch64.cc > +++ b/gcc/config/aarch64/aarch64.cc > @@ -22332,6 +22332,46 @@

Re: [aarch64] Code-gen for vector initialization involving constants

On Thu, 25 May 2023 at 01:28, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Wed, 24 May 2023 at 15:40, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Mon, 22 May 2023 at 14:18, Richard Sandiford > >> > wrote: > >> >> > >> >> Prathamesh Kulkarni

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Wed, 24 May 2023 at 15:40, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > On Mon, 22 May 2023 at 14:18, Richard Sandiford >> > wrote: >> >> >> >> Prathamesh Kulkarni writes: >> >> > Hi Richard, >> >> > Thanks for the suggestions. Does the

Re: [aarch64] Code-gen for vector initialization involving constants

On Wed, 24 May 2023 at 15:40, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Mon, 22 May 2023 at 14:18, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > Hi Richard, > >> > Thanks for the suggestions. Does the attached patch look OK ? > >> >

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Mon, 22 May 2023 at 14:18, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > Hi Richard, >> > Thanks for the suggestions. Does the attached patch look OK ? >> > Boostrap+test in progress on aarch64-linux-gnu. >> >> Like I say, please wait for the

Re: [aarch64] Code-gen for vector initialization involving constants

On Mon, 22 May 2023 at 14:18, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi Richard, > > Thanks for the suggestions. Does the attached patch look OK ? > > Boostrap+test in progress on aarch64-linux-gnu. > > Like I say, please wait for the tests to complete before sending an

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > Hi Richard, > Thanks for the suggestions. Does the attached patch look OK ? > Boostrap+test in progress on aarch64-linux-gnu. Like I say, please wait for the tests to complete before sending an RFA. It saves a review cycle if the tests don't in fact pass. > diff

Re: [aarch64] Code-gen for vector initialization involving constants

On Thu, 18 May 2023 at 22:04, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 18 May 2023 at 13:37, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Tue, 16 May 2023 at 00:29, Richard Sandiford > >> > wrote: > >> >> > >> >> Prathamesh Kulkarni

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Thu, 18 May 2023 at 13:37, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > On Tue, 16 May 2023 at 00:29, Richard Sandiford >> > wrote: >> >> >> >> Prathamesh Kulkarni writes: >> >> > Hi Richard, >> >> > After committing the interleave+zip1

Re: [aarch64] Code-gen for vector initialization involving constants

On Thu, 18 May 2023 at 13:37, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 16 May 2023 at 00:29, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > Hi Richard, > >> > After committing the interleave+zip1 patch for vector initialization, > >> > it

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Tue, 16 May 2023 at 00:29, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > Hi Richard, >> > After committing the interleave+zip1 patch for vector initialization, >> > it seems to regress the s32 case for this patch: >> > >> > int32x4_t

Re: [aarch64] Code-gen for vector initialization involving constants

On Tue, 16 May 2023 at 00:29, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi Richard, > > After committing the interleave+zip1 patch for vector initialization, > > it seems to regress the s32 case for this patch: > > > > int32x4_t f_s32(int32_t x) > > { > > return (int32x4_t)

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > Hi Richard, > After committing the interleave+zip1 patch for vector initialization, > it seems to regress the s32 case for this patch: > > int32x4_t f_s32(int32_t x) > { > return (int32x4_t) { x, x, x, 1 }; > } > > code-gen: > f_s32: > moviv30.2s, 0x1 >

Re: [aarch64] Code-gen for vector initialization involving constants

On Fri, 12 May 2023 at 00:45, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > > On Tue, 2 May 2023 at 18:22, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Tue, 2 May 2023 at 17:32, Richard Sandiford > >> > wrote: > >> >> > >> >> Prathamesh Kulkarni

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Tue, 2 May 2023 at 18:22, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > On Tue, 2 May 2023 at 17:32, Richard Sandiford >> > wrote: >> >> >> >> Prathamesh Kulkarni writes: >> >> > On Tue, 2 May 2023 at 14:56, Richard Sandiford >> >> >

Re: [aarch64] Code-gen for vector initialization involving constants

On Tue, 2 May 2023 at 18:22, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 2 May 2023 at 17:32, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Tue, 2 May 2023 at 14:56, Richard Sandiford > >> > wrote: > >> >> > [aarch64] Improve code-gen

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Tue, 2 May 2023 at 17:32, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > On Tue, 2 May 2023 at 14:56, Richard Sandiford >> > wrote: >> >> > [aarch64] Improve code-gen for vector initialization with single >> >> > constant element. >> >> > >>

Re: [aarch64] Code-gen for vector initialization involving constants

On Tue, 2 May 2023 at 17:32, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 2 May 2023 at 14:56, Richard Sandiford > > wrote: > >> > [aarch64] Improve code-gen for vector initialization with single > >> > constant element. > >> > > >> > gcc/ChangeLog: > >> > *

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Tue, 2 May 2023 at 14:56, Richard Sandiford > wrote: >> > [aarch64] Improve code-gen for vector initialization with single constant >> > element. >> > >> > gcc/ChangeLog: >> > * config/aarch64/aarc64.cc (aarch64_expand_vector_init): Tweak >> > condition

Re: [aarch64] Code-gen for vector initialization involving constants

On Tue, 2 May 2023 at 14:56, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 25 Apr 2023 at 16:29, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > Hi Richard, > >> > While digging thru aarch64_expand_vector_init, I noticed it gives > >> > priority

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > On Tue, 25 Apr 2023 at 16:29, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > Hi Richard, >> > While digging thru aarch64_expand_vector_init, I noticed it gives >> > priority to loading a constant first: >> > /* Initialise a vector which is

Re: [aarch64] Code-gen for vector initialization involving constants

On Tue, 25 Apr 2023 at 16:29, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi Richard, > > While digging thru aarch64_expand_vector_init, I noticed it gives > > priority to loading a constant first: > > /* Initialise a vector which is part-variable. We want to first try > >

Re: [aarch64] Code-gen for vector initialization involving constants

Prathamesh Kulkarni writes: > Hi Richard, > While digging thru aarch64_expand_vector_init, I noticed it gives > priority to loading a constant first: > /* Initialise a vector which is part-variable. We want to first try > to build those lanes which are constant in the most efficient way we

Re: [aarch64] Code-gen for vector initialization involving constants

On Mon, 13 Feb 2023 at 11:58, Prathamesh Kulkarni wrote: > > On Fri, 3 Feb 2023 at 12:46, Prathamesh Kulkarni > wrote: > > > > Hi Richard, > > While digging thru aarch64_expand_vector_init, I noticed it gives > > priority to loading a constant first: > > /* Initialise a vector which is

Re: [aarch64] Code-gen for vector initialization involving constants

On Fri, 3 Feb 2023 at 12:46, Prathamesh Kulkarni wrote: > > Hi Richard, > While digging thru aarch64_expand_vector_init, I noticed it gives > priority to loading a constant first: > /* Initialise a vector which is part-variable. We want to first try > to build those lanes which are

[aarch64] Code-gen for vector initialization involving constants

Hi Richard, While digging thru aarch64_expand_vector_init, I noticed it gives priority to loading a constant first: /* Initialise a vector which is part-variable. We want to first try to build those lanes which are constant in the most efficient way we can. */ which results in