Re: [fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-22 Thread Mike Stump
On Mar 22, 2012, at 3:40 PM, Bruce Korb wrote: > You can only figure out what has failed. Life goes on > Do I get the bonus points? make check and cat fixincludes.sum is necessary to get the bonus points. :-) Looks fine from what I can see.

Re: [fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-22 Thread Bruce Korb
Rather simple... In a file called fixinclude.sum, put PASS: unique string or FAIL: unique string one per line, Bonus points if you can total passes and failures: I think you just put it into the check template so it creates the result. Since multiple fixes tweak the same file, ther

Re: [fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-21 Thread Mike Stump
On Mar 21, 2012, at 2:46 PM, Mike Stump wrote: > echo "# of expected failures$(cat $file | grep 'FAIL:' | wc -l)" Oh, and if you expect perfection, you should use: echo "# of unexpected failures$(cat $file | grep 'FAIL:' | wc -l)" instead.

Re: [fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-21 Thread Mike Stump
On Mar 21, 2012, at 10:16 AM, Bruce Korb wrote: > Patch welcome! I, myself, don't know what "emit DejaGnu-style > fixincludes.{sum, log} files" would mean. Rather simple... In a file called fixinclude.sum, put PASS: unique string or FAIL: unique string one per line, as many times as you

Re: [fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-21 Thread Bruce Korb
Hi Rainer, On Wed, Mar 21, 2012 at 9:25 AM, Rainer Orth wrote: > As reported in PR other/52626, make check in fixincludes is currently > failing since I neglected to adapt the baseline for the Solaris 8 > removal ;-(  I always meant to run make check, but forgot. > > On the other hand, it would b

[fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-21 Thread Rainer Orth
As reported in PR other/52626, make check in fixincludes is currently failing since I neglected to adapt the baseline for the Solaris 8 removal ;-( I always meant to run make check, but forgot. On the other hand, it would be really helpful if fixincludes make check could emit DejaGnu-style fixinc