Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-09 Thread Ian Lance Taylor
On Tue, Oct 7, 2014 at 3:45 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: The only points in that patch are that on one hand - as far as I know - the Abi does not guarantee that section symbols are either zero or not relocated, even if that may be the case in reality. And on the other hand,

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-07 Thread Dominik Vogt
On Mon, Oct 06, 2014 at 07:29:33AM -0700, Ian Lance Taylor wrote: On Mon, Oct 6, 2014 at 12:42 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: On s390[x] the symbol value of a section symbol is definitely not zero. Is true even in an object file? No. I agree that in an executable a

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-06 Thread Dominik Vogt
On Fri, Oct 03, 2014 at 06:25:55PM -0700, Ian Lance Taylor wrote: On Tue, Sep 9, 2014 at 5:56 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: * libgo/go/debug/elf/file.go (applyRelocationsAMD64): Fix the calculation of some relocations; do not assume that the symbol

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-06 Thread Ian Lance Taylor
On Mon, Oct 6, 2014 at 12:42 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: On s390[x] the symbol value of a section symbol is definitely not zero. Is true even in an object file? I agree that in an executable a section symbol will have a non-zero value, but that case doesn't arise since an

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-03 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:56 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: This optional cleanup patch fixes some sloppy programming in the x86 libgo/go/debug/elf library that had given me a very hard time to debug and fix when porting the code to s390[x]. See commit comment for details.