Re: [gofrontend-dev] Re: libgo: Update to Go 1.13beta1 release

2019-09-12 Thread Andreas Schwab 
On Sep 11 2019, Ian Lance Taylor  wrote:

> On Tue, Sep 10, 2019 at 11:54 PM Andreas Schwab  wrote:
>>
>> On Sep 10 2019, Ian Lance Taylor  wrote:
>>
>> > On Mon, Sep 9, 2019 at 2:00 PM Andreas Schwab  
>> > wrote:
>> >>
>> >> ../../../libgo/go/golang.org/x/sys/cpu/cpu.go:17:30: error: reference to 
>> >> undefined name ‘cacheLineSize’
>> >>17 | type CacheLinePad struct{ _ [cacheLineSize]byte }
>> >>   |  ^
>> >> ../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: 
>> >> reference to undefined name ‘doinit’
>> >>56 |  doinit()
>> >>   |  ^
>> >
>> > Thanks, should be fixed by SVN revision 275611, just committed.
>>
>> Nope.
>>
>> ../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: reference 
>> to undefined name 'doinit'
>>56 |  doinit()
>>   |  ^
>> make[4]: *** [golang.org/x/sys/cpu.lo] Error 1
>
> Bother, sorry.  I just committed this patch.  Perhaps this will fix it.

It does.

Thanks, Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [gofrontend-dev] Re: libgo: Update to Go 1.13beta1 release

2019-09-11 Thread Ian Lance Taylor 
On Tue, Sep 10, 2019 at 11:54 PM Andreas Schwab  wrote:
>
> On Sep 10 2019, Ian Lance Taylor  wrote:
>
> > On Mon, Sep 9, 2019 at 2:00 PM Andreas Schwab  wrote:
> >>
> >> ../../../libgo/go/golang.org/x/sys/cpu/cpu.go:17:30: error: reference to 
> >> undefined name ‘cacheLineSize’
> >>17 | type CacheLinePad struct{ _ [cacheLineSize]byte }
> >>   |  ^
> >> ../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: reference 
> >> to undefined name ‘doinit’
> >>56 |  doinit()
> >>   |  ^
> >
> > Thanks, should be fixed by SVN revision 275611, just committed.
>
> Nope.
>
> ../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: reference to 
> undefined name 'doinit'
>56 |  doinit()
>   |  ^
> make[4]: *** [golang.org/x/sys/cpu.lo] Error 1

Bother, sorry.  I just committed this patch.  Perhaps this will fix it.

Ian
Index: gcc/go/gofrontend/MERGE
===
--- gcc/go/gofrontend/MERGE (revision 275648)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-1f4ce28409a2d9d4045b1085de55c46de8759d1c
+27b2311fa460b1dd76fb3a796c7c05ebedc64df2
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/go/golang.org/x/sys/cpu/cpu_linux_other.go
===
--- libgo/go/golang.org/x/sys/cpu/cpu_linux_other.go(nonexistent)
+++ libgo/go/golang.org/x/sys/cpu/cpu_linux_other.go(working copy)
@@ -0,0 +1,9 @@
+// Copyright 2019 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// +build !amd64,!amd64p32,!386,!arm64,!ppc64,!ppc64le,!s390x
+
+package cpu
+
+func doinit() {}

Re: [gofrontend-dev] Re: libgo: Update to Go 1.13beta1 release

2019-09-11 Thread Andreas Schwab 
On Sep 10 2019, Ian Lance Taylor  wrote:

> On Mon, Sep 9, 2019 at 2:00 PM Andreas Schwab  wrote:
>>
>> ../../../libgo/go/golang.org/x/sys/cpu/cpu.go:17:30: error: reference to 
>> undefined name ‘cacheLineSize’
>>17 | type CacheLinePad struct{ _ [cacheLineSize]byte }
>>   |  ^
>> ../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: reference 
>> to undefined name ‘doinit’
>>56 |  doinit()
>>   |  ^
>
> Thanks, should be fixed by SVN revision 275611, just committed.

Nope.

../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: reference to 
undefined name 'doinit'
   56 |  doinit()
  |  ^
make[4]: *** [golang.org/x/sys/cpu.lo] Error 1

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [gofrontend-dev] Re: libgo: Update to Go 1.13beta1 release

2019-09-10 Thread Ian Lance Taylor 
On Mon, Sep 9, 2019 at 2:00 PM Andreas Schwab  wrote:
>
> ../../../libgo/go/golang.org/x/sys/cpu/cpu.go:17:30: error: reference to 
> undefined name ‘cacheLineSize’
>17 | type CacheLinePad struct{ _ [cacheLineSize]byte }
>   |  ^
> ../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: reference to 
> undefined name ‘doinit’
>56 |  doinit()
>   |  ^

Thanks, should be fixed by SVN revision 275611, just committed.

Ian

Re: [gofrontend-dev] Re: libgo: Update to Go 1.13beta1 release

2019-09-09 Thread Andreas Schwab 
../../../libgo/go/golang.org/x/sys/cpu/cpu.go:17:30: error: reference to 
undefined name ‘cacheLineSize’
   17 | type CacheLinePad struct{ _ [cacheLineSize]byte }
  |  ^
../../../libgo/go/golang.org/x/sys/cpu/cpu_linux.go:56:2: error: reference to 
undefined name ‘doinit’
   56 |  doinit()
  |  ^

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [gofrontend-dev] Re: libgo: Update to Go 1.13beta1 release

2019-09-09 Thread Ian Lance Taylor 
On Sat, Sep 7, 2019 at 8:20 AM Andreas Schwab  wrote:
>
> On Sep 07 2019, Bernd Edlinger  wrote:
>
> > Hi Ian,
> >
> >> gotools:
> >>
> >> 2019-09-06  Ian Lance Taylor  
> >>
> >> * Makefile.am (check-carchive-test): Just run "go test", not "go
> >> test carchive_test.go".
> >> * Makefile.in: Regenerate.
> >>
> >> gcc/testsuite:
> >>
> >> 2019-09-06  Ian Lance Taylor  
> >>
> >> * go.test/test/fixedbugs/bug369.go: Update to match libgo update
> >> to Go 1.13beta1.
> >>
> >
> > this patch can't build on arm anymore:
>
> Or any other non-x86 architecture.

Sorry for the breakage.  I just committed this patch, which should fix
the problem.  Let me know if it doesn't.

Ian
Index: gcc/go/gofrontend/MERGE
===
--- gcc/go/gofrontend/MERGE (revision 275540)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-17bef47f464983fd8513f88f3f159d28e2423e79
+03fa49394bb4b37453795bef3119e5b40c929aee
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/Makefile.am
===
--- libgo/Makefile.am   (revision 275473)
+++ libgo/Makefile.am   (working copy)
@@ -683,6 +683,12 @@ else
 syscall_lib_clone_lo =
 endif
 
+if LIBGO_IS_X86
+golangorg_x_sys_cpu_gccgo_lo = golang.org/x/sys/cpu_gccgo.lo
+else
+golangorg_x_sys_cpu_gccgo_lo =
+endif
+
 PACKAGES = $(shell cat $(srcdir)/libgo-packages.txt)
 
 libgo_go_objs = \
@@ -700,7 +706,7 @@ libgo_go_objs = \
runtime/internal/atomic_c.lo \
sync/atomic_c.lo \
internal/cpu/cpu_gccgo.lo \
-   golang.org/x/sys/cpu_gccgo.lo
+   $(golangorg_x_sys_cpu_gccgo_lo)
 
 libgo_ldflags = \
-version-info $(libtool_VERSION) $(PTHREAD_CFLAGS) $(AM_LDFLAGS)
Index: libgo/configure.ac
===
--- libgo/configure.ac  (revision 275473)
+++ libgo/configure.ac  (working copy)
@@ -354,6 +354,8 @@ AC_SUBST(GOARCH)
 AC_SUBST(ALLGOARCH)
 AC_SUBST(ALLGOARCHFAMILY)
 
+AM_CONDITIONAL(LIBGO_IS_X86, test "$GOARCH" = "386" -o "$GOARCH" = "amd64" -o 
"$GOARCH" = "amd64p32")
+
 FUNCTION_DESCRIPTORS=false
 case ${host} in
   rs6000*-*-* | powerpc*-*-*)