[google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
Hi, I have attached a patch for the reordering plugin to display appropriate error messages when incorrect options are passed or when some API is unavailable. The plugin will use the ld_plugin_message linker API to flag errors (fatal or non-fatal) when incorrect options are passed or when

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Xinliang David Li
when split_segment is specified but the API does not exist, why not making it fatal ? Will it crash at some point when the null pointer is referenced later? David On Wed, Feb 13, 2013 at 4:19 PM, Sriraman Tallam tmsri...@google.com wrote: Hi, I have attached a patch for the reordering

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
On Wed, Feb 13, 2013 at 4:32 PM, Xinliang David Li davi...@google.com wrote: when split_segment is specified but the API does not exist, why not making it fatal ? Will it crash at some point when the null pointer is referenced later? It cannot be referenced later as the handlers will not get

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
Updated patch attached. Thanks Sri On Wed, Feb 13, 2013 at 4:39 PM, Sriraman Tallam tmsri...@google.com wrote: On Wed, Feb 13, 2013 at 4:32 PM, Xinliang David Li davi...@google.com wrote: when split_segment is specified but the API does not exist, why not making it fatal ? Will it crash at

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Xinliang David Li
ok. thanks, David On Wed, Feb 13, 2013 at 4:41 PM, Sriraman Tallam tmsri...@google.com wrote: Updated patch attached. Thanks Sri On Wed, Feb 13, 2013 at 4:39 PM, Sriraman Tallam tmsri...@google.com wrote: On Wed, Feb 13, 2013 at 4:32 PM, Xinliang David Li davi...@google.com wrote: