ok for google branches.
David
On Tue, Nov 6, 2012 at 5:17 PM, Harshit Chopra hars...@google.com wrote:
Yes, will do, but probably not so soon. Once I have some spare time to
prepare my case for this being useful to public.
Meanwhile, this patch is just for google-main and then I will port it
Yes, will do, but probably not so soon. Once I have some spare time to
prepare my case for this being useful to public.
Meanwhile, this patch is just for google-main and then I will port it
to google_4-7 and adds to the already existing functionality of
-mpatch-function-for-instrumentation.
2012-11-05 Harshit Chopra hars...@google.com
* gcc/c-family/c-common.c
(handle_always_patch_for_instrumentation_attribute): Handle
always_patch_for_instrumentation attribute and turn inlining off for the
function.
(handle_never_patch_for_instrumentation_attribute): Handle
Thanks David for the review. My comments are inline.
On Sat, Nov 3, 2012 at 12:38 PM, Xinliang David Li davi...@google.com wrote:
Harshit, Nov 5 is the gcc48 cutoff date. If you want to have the x-ray
instrumentation feature into this release, you will need to port your
patch and submit for
It does not hurt to submit the patch for review -- you need to provide
more background and motivation for this work
1) comparison with -finstrument-functions (runtime overhead etc)
2) use model difference (production binary ..)
3) Interesting examples of use cases (with graphs).
thanks,
David
Harshit, Nov 5 is the gcc48 cutoff date. If you want to have the x-ray
instrumentation feature into this release, you will need to port your
patch and submit for trunk review now.
On Tue, Oct 30, 2012 at 5:15 PM, Harshit Chopra hars...@google.com wrote:
Adding function attributes:
Adding function attributes: 'always_patch_for_instrumentation' and
'never_patch_for_instrumentation' to always patch a function or to never patch
a function, respectively, when given the option
-mpatch-functions-for-instrumentation. Additionally, the attribute
always_patch_for_instrumentation
