Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread davidxl
http://codereview.appspot.com/6306054/diff/1/cgraph.h File cgraph.h (right): http://codereview.appspot.com/6306054/diff/1/cgraph.h#newcode410 cgraph.h:410: Why not putting this into value-prof.h? http://codereview.appspot.com/6306054/diff/1/ipa-split.c File ipa-split.c (right):

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread xur
will send the new patch set in a few minutes. http://codereview.appspot.com/6306054/diff/1/cgraph.h File cgraph.h (right): http://codereview.appspot.com/6306054/diff/1/cgraph.h#newcode410 cgraph.h:410: They are referenced in lto-cgraph.c etc. On 2012/06/07 21:46:53, davidxl wrote: Why not

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread Rong Xu
On Thu, Jun 7, 2012 at 3:22 PM, x...@google.com wrote: will send the new patch set in a few minutes. http://codereview.appspot.com/6306054/diff/1/cgraph.h File cgraph.h (right): http://codereview.appspot.com/6306054/diff/1/cgraph.h#newcode410 cgraph.h:410: They are referenced in

Re: [google-4_6] indirect_call promotion for streaming LIPO (issue 6306054)

2012-06-07 Thread davidxl
ok for google branches -- LTO specific bugs should be isolated and submitted upstream. David http://codereview.appspot.com/6306054/diff/5001/value-prof.c File value-prof.c (right): http://codereview.appspot.com/6306054/diff/5001/value-prof.c#newcode1720 value-prof.c:1720: direct_call2 = 0; Ok